From: "Lluís Vilanova" <vilanova@ac.upc.edu>
To: qemu-devel@nongnu.org
Cc: stefanha@gmail.com, harsh@linux.vnet.ibm.com,
aneesh.kumar@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH v7 03/11] trace: [tracetool] Do not rebuild event list in backend code
Date: Wed, 21 Mar 2012 22:52:44 +0100 [thread overview]
Message-ID: <20120321215244.3272.63786.stgit@ginnungagap.bsc.es> (raw)
In-Reply-To: <20120321215224.3272.37570.stgit@ginnungagap.bsc.es>
Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
Signed-off-by: Harsh Prateek Bora <harsh@linux.vnet.ibm.com>
---
scripts/tracetool.py | 9 +++++----
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/scripts/tracetool.py b/scripts/tracetool.py
index 33e3c26..ff1519c 100755
--- a/scripts/tracetool.py
+++ b/scripts/tracetool.py
@@ -240,8 +240,7 @@ def ust_c(events):
#undef inline
#undef wmb
#include "trace.h"'''
- eventlist = list(events)
- for event in eventlist:
+ for event in events:
argnames = event.argnames
if event.argc > 0:
argnames = ', ' + event.argnames
@@ -273,7 +272,7 @@ static void ust_%(name)s_probe(%(args)s)
print '''
static void __attribute__((constructor)) trace_init(void)
{'''
- for event in eventlist:
+ for event in events:
print ' register_trace_ust_%(name)s(ust_%(name)s_probe);' % {
'name': event.name
}
@@ -415,13 +414,15 @@ class Event(object):
# Generator that yields Event objects given a trace-events file object
def read_events(fobj):
event_num = 0
+ res = []
for line in fobj:
if not line.strip():
continue
if line.lstrip().startswith('#'):
continue
- yield Event(event_num, line)
+ res.append(Event(event_num, line))
event_num += 1
+ return res
binary = ""
probeprefix = ""
next prev parent reply other threads:[~2012-03-21 21:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 21:52 [Qemu-devel] [PATCH v7 00/11] Rewrite tracetool using python Lluís Vilanova
2012-03-21 21:52 ` [Qemu-devel] [PATCH v7 01/11] Converting tracetool.sh to tracetool.py Lluís Vilanova
2012-03-21 21:52 ` [Qemu-devel] [PATCH v7 02/11] trace: [tracetool] Remove unused 'sizestr' attribute in 'Event' Lluís Vilanova
2012-03-21 21:52 ` Lluís Vilanova [this message]
2012-03-21 21:52 ` [Qemu-devel] [PATCH v7 04/11] trace: [tracetool] Simplify event line parsing Lluís Vilanova
2012-03-21 21:52 ` [Qemu-devel] [PATCH v7 05/11] trace: [tracetool] Do not precompute the event number Lluís Vilanova
2012-03-21 21:53 ` [Qemu-devel] [PATCH v7 06/11] trace: [tracetool] Add support for event properties Lluís Vilanova
2012-03-21 21:53 ` [Qemu-devel] [PATCH v7 07/11] trace: [tracetool] Process the "disable" event property Lluís Vilanova
2012-03-21 21:53 ` [Qemu-devel] [PATCH v7 08/11] trace: [tracetool] Rewrite event argument parsing Lluís Vilanova
2012-03-21 21:53 ` [Qemu-devel] [PATCH v7 09/11] trace: [tracetool] Make format-specific code optional and with access to events Lluís Vilanova
2012-03-21 21:53 ` [Qemu-devel] [PATCH v7 10/11] trace: Provide a per-event status define for conditional compilation Lluís Vilanova
2012-03-21 21:53 ` [Qemu-devel] [PATCH v7 11/11] trace: [tracetool] Add error-reporting functions Lluís Vilanova
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120321215244.3272.63786.stgit@ginnungagap.bsc.es \
--to=vilanova@ac.upc.edu \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=harsh@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).