* [Qemu-devel] block stream: close unused files and update ->backing_hd
@ 2012-03-22 1:09 Marcelo Tosatti
2012-03-22 12:53 ` Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: Marcelo Tosatti @ 2012-03-22 1:09 UTC (permalink / raw)
To: Stefan Hajnoczi, Kevin Wolf; +Cc: qemu-devel
Close the now unused images that were part of the previous backing file
chain and adjust ->backing_hd properly.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=801449
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
diff --git a/block/stream.c b/block/stream.c
index d1b3986..cbf041b 100644
--- a/block/stream.c
+++ b/block/stream.c
@@ -76,6 +76,29 @@ static int coroutine_fn stream_populate(BlockDriverState *bs,
return bdrv_co_copy_on_readv(bs, sector_num, nb_sectors, &qiov);
}
+static void close_unused_images(BlockDriverState *top, BlockDriverState *base)
+{
+ BlockDriverState *intermediate;
+ intermediate = top->backing_hd;
+
+ while (intermediate) {
+ BlockDriverState *unused;
+
+ /* reached base */
+ if (intermediate == base) {
+ break;
+ }
+
+ unused = intermediate;
+ intermediate = intermediate->backing_hd;
+ unused->backing_hd = NULL;
+ bdrv_delete(unused);
+ }
+ top->backing_hd = base;
+
+ return;
+}
+
/*
* Given an image chain: [BASE] -> [INTER1] -> [INTER2] -> [TOP]
*
@@ -221,6 +244,7 @@ retry:
base_id = s->backing_file_id;
}
ret = bdrv_change_backing_file(bs, base_id, NULL);
+ close_unused_images(bs, base);
}
qemu_vfree(buf);
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-22 12:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-22 1:09 [Qemu-devel] block stream: close unused files and update ->backing_hd Marcelo Tosatti
2012-03-22 12:53 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).