From: David Gibson <dwg@au1.ibm.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: aliguori@us.ibm.com, Rusty Russell <rusty@rustcorp.com.au>,
qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Remove PCI class code from virtio balloon device
Date: Thu, 22 Mar 2012 21:52:46 +1100 [thread overview]
Message-ID: <20120322105246.GC9087@truffala.fritz.box> (raw)
In-Reply-To: <CAJSP0QUCrdUsYP_r03jxsrqq0EeKAxH6cG+0+SxQAhwQMkhcTg@mail.gmail.com>
On Thu, Mar 22, 2012 at 10:01:46AM +0000, Stefan Hajnoczi wrote:
> On Thu, Mar 22, 2012 at 9:09 AM, David Gibson
> <david@gibson.dropbear.id.au> wrote:
> > diff --git a/hw/pc_piix.c b/hw/pc_piix.c
> > index 3f99f9a..72a4250 100644
> > --- a/hw/pc_piix.c
> > +++ b/hw/pc_piix.c
> > @@ -386,6 +386,10 @@ static QEMUMachine pc_machine_v1_0 = {
> > .driver = "isa-fdc",
> > .property = "check_media_rate",
> > .value = "off",
> > + }, {
> > + .driver = "virtio-balloon-pci",
> > + .property = "class",
> > + .value = stringify(PCI_CLASS_MEMORY_RAM),
> > },
> > { /* end of list */ }
> > },
> > @@ -449,6 +453,10 @@ static QEMUMachine pc_machine_v0_14 = {
>
> pc_machine_v0_15 should also use PCI_CLASS_MEMORY_RAM? Did you skip
> it on purpose?
Nope, just missed it. I'll respin.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2012-03-22 11:57 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-22 9:09 [Qemu-devel] [PATCH] Remove PCI class code from virtio balloon device David Gibson
2012-03-22 10:01 ` Stefan Hajnoczi
2012-03-22 10:27 ` Gerd Hoffmann
2012-03-22 10:32 ` Stefan Hajnoczi
2012-03-22 10:52 ` David Gibson [this message]
2012-03-22 11:53 ` Michael S. Tsirkin
2012-03-23 1:52 ` David Gibson
2012-03-23 12:54 ` Anthony Liguori
-- strict thread matches above, loose matches on Subject: below --
2012-03-26 1:19 David Gibson
2012-04-02 2:43 ` David Gibson
2012-04-02 6:46 ` Michael S. Tsirkin
2012-04-02 6:49 ` David Gibson
2012-04-02 7:11 ` Michael S. Tsirkin
2012-04-03 14:31 ` Michael S. Tsirkin
2012-03-19 4:59 David Gibson
2012-03-19 11:33 ` Stefan Hajnoczi
2012-03-20 0:42 ` David Gibson
2012-03-20 9:54 ` Stefan Hajnoczi
2012-03-20 10:19 ` David Gibson
2012-03-21 11:26 ` Stefan Hajnoczi
2012-03-21 11:28 ` Stefan Hajnoczi
2012-03-21 13:24 ` David Gibson
2012-03-21 13:08 ` Michael S. Tsirkin
2012-03-21 14:42 ` Anthony Liguori
2012-03-21 15:10 ` Michael S. Tsirkin
2012-03-21 15:14 ` Anthony Liguori
2012-03-21 16:11 ` Michael S. Tsirkin
2012-03-21 16:26 ` Anthony Liguori
2012-03-21 16:33 ` Anthony Liguori
2012-03-21 18:28 ` Michael S. Tsirkin
2012-03-21 18:11 ` Michael S. Tsirkin
2012-03-20 10:53 ` Michael S. Tsirkin
2012-03-16 1:03 David Gibson
2012-03-18 12:38 ` Michael S. Tsirkin
2012-03-19 2:17 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120322105246.GC9087@truffala.fritz.box \
--to=dwg@au1.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).