From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53201) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SAgdg-000096-Gs for qemu-devel@nongnu.org; Thu, 22 Mar 2012 07:57:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SAgde-0006Jz-HM for qemu-devel@nongnu.org; Thu, 22 Mar 2012 07:57:08 -0400 Received: from e23smtp05.au.ibm.com ([202.81.31.147]:33501) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SAgdd-0006G0-Nf for qemu-devel@nongnu.org; Thu, 22 Mar 2012 07:57:06 -0400 Received: from /spool/local by e23smtp05.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 22 Mar 2012 11:52:36 +1000 Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q2MBoLno2855138 for ; Thu, 22 Mar 2012 22:50:21 +1100 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q2MBuLW8017217 for ; Thu, 22 Mar 2012 22:56:21 +1100 Date: Thu, 22 Mar 2012 21:52:46 +1100 From: David Gibson Message-ID: <20120322105246.GC9087@truffala.fritz.box> References: <1332407367-26551-1-git-send-email-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] Remove PCI class code from virtio balloon device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: aliguori@us.ibm.com, Rusty Russell , qemu-devel@nongnu.org, "Michael S. Tsirkin" On Thu, Mar 22, 2012 at 10:01:46AM +0000, Stefan Hajnoczi wrote: > On Thu, Mar 22, 2012 at 9:09 AM, David Gibson > wrote: > > diff --git a/hw/pc_piix.c b/hw/pc_piix.c > > index 3f99f9a..72a4250 100644 > > --- a/hw/pc_piix.c > > +++ b/hw/pc_piix.c > > @@ -386,6 +386,10 @@ static QEMUMachine pc_machine_v1_0 = { > >             .driver   = "isa-fdc", > >             .property = "check_media_rate", > >             .value    = "off", > > +        }, { > > +            .driver   = "virtio-balloon-pci", > > +            .property = "class", > > +            .value    = stringify(PCI_CLASS_MEMORY_RAM), > >         }, > >         { /* end of list */ } > >     }, > > @@ -449,6 +453,10 @@ static QEMUMachine pc_machine_v0_14 = { > > pc_machine_v0_15 should also use PCI_CLASS_MEMORY_RAM? Did you skip > it on purpose? Nope, just missed it. I'll respin. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson