From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34586)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SB7xo-0007AT-Vi
	for qemu-devel@nongnu.org; Fri, 23 Mar 2012 13:07:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SB7xk-0001Oo-L4
	for qemu-devel@nongnu.org; Fri, 23 Mar 2012 13:07:44 -0400
Received: from mx1.redhat.com ([209.132.183.28]:21024)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SB7xk-0001OZ-Dt
	for qemu-devel@nongnu.org; Fri, 23 Mar 2012 13:07:40 -0400
Date: Fri, 23 Mar 2012 14:07:37 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120323140737.28265fae@doriath.home>
In-Reply-To: <20120323.170622.115912902.d.hatayama@jp.fujitsu.com>
References: <4F680037.9090101@cn.fujitsu.com>
	<20120323.170622.115912902.d.hatayama@jp.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 11/11 v10] introduce a new monitor command
 'dump-guest-memory' to dump guest's memory
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
Cc: jan.kiszka@siemens.com, qemu-devel@nongnu.org, anderson@redhat.com, anthony@codemonkey.ws, eblake@redhat.com

On Fri, 23 Mar 2012 17:06:22 +0900 (   )
HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com> wrote:

> From: Wen Congyang <wency@cn.fujitsu.com>
> Subject: [PATCH 11/11 v10] introduce a new monitor command 'dump-guest-memory' to dump guest's memory
> Date: Tue, 20 Mar 2012 11:57:43 +0800
> 
> <cut>
> 
> > +typedef struct DumpState {
> > +    ArchDumpInfo dump_info;
> > +    MemoryMappingList list;
> > +    uint16_t phdr_num;
> > +    uint32_t sh_info;
> > +    bool have_section;
> > +    bool resume;
> > +    target_phys_addr_t memory_offset;
> > +    write_core_dump_function f;
> 
> f() is so general. Type information is meaningless enough, but there's
> no explicit occurence of the function call of f(). Could you consider
> renaming?

Agreed. I actually don't see why this indirection is needed.