From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:43510)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SB8DG-0005jh-NY
	for qemu-devel@nongnu.org; Fri, 23 Mar 2012 13:23:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SB8DC-0005Aa-1J
	for qemu-devel@nongnu.org; Fri, 23 Mar 2012 13:23:42 -0400
Received: from mx1.redhat.com ([209.132.183.28]:19280)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SB8DB-0005AM-Lq
	for qemu-devel@nongnu.org; Fri, 23 Mar 2012 13:23:37 -0400
Date: Fri, 23 Mar 2012 14:23:36 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120323142336.7df904a5@doriath.home>
In-Reply-To: <4F67F951.6010102@cn.fujitsu.com>
References: <4F67F951.6010102@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 00/11 v10] introducing a new,
 dedicated guest memory dump mechanism
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: aliguori@us.ibm.com, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel <qemu-devel@nongnu.org>, HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>, Dave Anderson <anderson@redhat.com>, Eric Blake <eblake@redhat.com>

On Tue, 20 Mar 2012 11:28:17 +0800
Wen Congyang <wency@cn.fujitsu.com> wrote:

> Hi, all
> 
> 'virsh dump' can not work when host pci device is used by guest. We have
> discussed this issue here:
> http://lists.nongnu.org/archive/html/qemu-devel/2011-10/msg00736.html

I've reviewed the QMP part of this series and it looks good to me (only
spot small things).

Now, I'd like to get an ACK from Jan and/or Anthony before applying,
specially wrt the fact this is a long running synchronous command (btw,
I think this is ok, as this command is more likely to run when the VM
guest crashes...).