From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40852)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SBBEa-0000cI-61
	for qemu-devel@nongnu.org; Fri, 23 Mar 2012 16:37:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SBBEY-0006qN-EB
	for qemu-devel@nongnu.org; Fri, 23 Mar 2012 16:37:15 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58060)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SBBEY-0006qB-66
	for qemu-devel@nongnu.org; Fri, 23 Mar 2012 16:37:14 -0400
Date: Fri, 23 Mar 2012 17:37:15 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120323173715.10836950@doriath.home>
In-Reply-To: <20120323191153.GB2219@illuin>
References: <0ccd5fa1764f254dbde6851c0d2139e9198a25e2.1332256180.git.mprivozn@redhat.com>
	<1332291249-18212-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<20120323152022.1251ed9d@doriath.home>
	<20120323191153.GB2219@illuin>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qemu-ga: stub out guest-suspend* for
 non-linux
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: mprivozn@redhat.com, qemu-devel@nongnu.org

On Fri, 23 Mar 2012 14:11:53 -0500
Michael Roth <mdroth@linux.vnet.ibm.com> wrote:

> On Fri, Mar 23, 2012 at 03:20:22PM -0300, Luiz Capitulino wrote:
> > On Tue, 20 Mar 2012 19:54:09 -0500
> > Michael Roth <mdroth@linux.vnet.ibm.com> wrote:
> > 
> > > This currently breaks the build for BSDs.
> > > 
> > > Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
> > > ---
> > >  qga/commands-posix.c |   22 ++++++++++++++++++++++
> > >  1 files changed, 22 insertions(+), 0 deletions(-)
> > > 
> > > diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> > > index 89dde92..16737d7 100644
> > > --- a/qga/commands-posix.c
> > > +++ b/qga/commands-posix.c
> > > @@ -24,10 +24,12 @@
> > >  
> > >  #include <sys/types.h>
> > >  #include <sys/ioctl.h>
> > > +#if defined(__linux__)
> > >  #include <ifaddrs.h>
> > >  #include <arpa/inet.h>
> > >  #include <sys/socket.h>
> > >  #include <net/if.h>
> > > +#endif
> > >  #include <sys/wait.h>
> > >  #include "qga/guest-agent-core.h"
> > >  #include "qga-qmp-commands.h"
> > > @@ -542,6 +544,7 @@ int64_t qmp_guest_fsfreeze_thaw(Error **err)
> > >  #define SUSPEND_SUPPORTED 0
> > >  #define SUSPEND_NOT_SUPPORTED 1
> > 
> > Missing the macros and I think reopen_fd_to_null() is missing too, also
> > doesn't apply to latest master.
> > 
> 
> Shouldn't hurt, but yah, leaving them in is a bit sloppy.

I think letting reopen_fd_to_null() out won't actually build.

> Don't see why this wouldn't apply though... are you applying on top of
> Michal's patch?

Oh, no, I was trying to apply on master to test it... If Michal's patch
is not applied yet, then I think you should post a version that applies
on master and Michal should rebase on top of your patch.

> This patch was meant to be the guest-suspend counterpart
> rather than a standalone fix.

Yeah, I missed it. I'm sorry for that and thanks for fixing it!