From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: Brad Smith <brad@comstyle.com>
Cc: Michal Privoznik <mprivozn@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command
Date: Sun, 25 Mar 2012 14:47:41 -0500 [thread overview]
Message-ID: <20120325194741.GA8313@illuin> (raw)
In-Reply-To: <4F6E7298.5050601@comstyle.com>
On Sat, Mar 24, 2012 at 09:19:20PM -0400, Brad Smith wrote:
> On 20/03/12 9:28 AM, Brad Smith wrote:
> >On 20/03/12 6:14 AM, Michal Privoznik wrote:
> >>On 18.03.2012 02:09, Brad Smith wrote:
> >>>Michal,
> >>>
> >>>http://git.qemu.org/?p=qemu.git;a=commit;h=3424fc9f16a1e7d1c48eb6d605eb0ca63e199ec2
> >>>
> >>>
> >>>
> >>>This broke the build. Un-break the tree.
> >>>
> >>
> >>
> >>Can you please be more specific? It works for me so I don't have a clue
> >>what are you referring to. I mean, what compiler do you use, what errors
> >>are thrown, etc.
> >>
> >>Michal
> >
> >The patch commited is full of Linux specific code.
>
> This is *STILL BROKEN*. If you can't get a fix in in a timely manner
> then REVERT
> the broken commit.
Hi Brad,
Just CC'd you on an updated patch from one that Michal sent out earlier
in the week. Don't have a BSD handy to test with so please give it a whirl
and see if it does the job. If so I'll send a PULL first thing in the morning.
In the meantime you can use --disable-guest-agent to skip the qemu-ga
build.
Sorry for the breakage, I'll work on getting a BSD vm together to test future
PULLs.
>
> --
> This message has been scanned for viruses and
> dangerous content by MailScanner, and is
> believed to be clean.
>
>
next prev parent reply other threads:[~2012-03-25 19:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-18 1:09 [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command Brad Smith
2012-03-20 10:14 ` Michal Privoznik
2012-03-20 13:28 ` Brad Smith
2012-03-25 1:19 ` Brad Smith
2012-03-25 19:47 ` Michael Roth [this message]
2012-03-26 9:28 ` Michal Privoznik
2012-03-26 14:53 ` Michael Roth
2012-03-26 14:55 ` Anthony Liguori
2012-03-26 15:15 ` Michael Roth
2012-03-26 15:18 ` Anthony Liguori
2012-03-26 15:20 ` Michal Privoznik
2012-03-26 17:07 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120325194741.GA8313@illuin \
--to=mdroth@linux.vnet.ibm.com \
--cc=brad@comstyle.com \
--cc=mprivozn@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).