From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35250) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SBtPp-0005DR-Bs for qemu-devel@nongnu.org; Sun, 25 Mar 2012 15:47:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SBtPn-0002uB-Gf for qemu-devel@nongnu.org; Sun, 25 Mar 2012 15:47:48 -0400 Received: from mail-ob0-f173.google.com ([209.85.214.173]:42582) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SBtPn-0002tr-6E for qemu-devel@nongnu.org; Sun, 25 Mar 2012 15:47:47 -0400 Received: by obbwd20 with SMTP id wd20so5028800obb.4 for ; Sun, 25 Mar 2012 12:47:45 -0700 (PDT) Sender: fluxion Date: Sun, 25 Mar 2012 14:47:41 -0500 From: Michael Roth Message-ID: <20120325194741.GA8313@illuin> References: <4F6535B5.4040405@comstyle.com> <4F685882.2070105@redhat.com> <4F6885E0.1050708@comstyle.com> <4F6E7298.5050601@comstyle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F6E7298.5050601@comstyle.com> Subject: Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Brad Smith Cc: Michal Privoznik , qemu-devel On Sat, Mar 24, 2012 at 09:19:20PM -0400, Brad Smith wrote: > On 20/03/12 9:28 AM, Brad Smith wrote: > >On 20/03/12 6:14 AM, Michal Privoznik wrote: > >>On 18.03.2012 02:09, Brad Smith wrote: > >>>Michal, > >>> > >>>http://git.qemu.org/?p=qemu.git;a=commit;h=3424fc9f16a1e7d1c48eb6d605eb0ca63e199ec2 > >>> > >>> > >>> > >>>This broke the build. Un-break the tree. > >>> > >> > >> > >>Can you please be more specific? It works for me so I don't have a clue > >>what are you referring to. I mean, what compiler do you use, what errors > >>are thrown, etc. > >> > >>Michal > > > >The patch commited is full of Linux specific code. > > This is *STILL BROKEN*. If you can't get a fix in in a timely manner > then REVERT > the broken commit. Hi Brad, Just CC'd you on an updated patch from one that Michal sent out earlier in the week. Don't have a BSD handy to test with so please give it a whirl and see if it does the job. If so I'll send a PULL first thing in the morning. In the meantime you can use --disable-guest-agent to skip the qemu-ga build. Sorry for the breakage, I'll work on getting a BSD vm together to test future PULLs. > > -- > This message has been scanned for viruses and > dangerous content by MailScanner, and is > believed to be clean. > >