From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59517) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SC9Le-0003b9-Mp for qemu-devel@nongnu.org; Mon, 26 Mar 2012 08:48:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SC9LU-0001R3-Cv for qemu-devel@nongnu.org; Mon, 26 Mar 2012 08:48:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30770) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SC9LU-0001Qh-4j for qemu-devel@nongnu.org; Mon, 26 Mar 2012 08:48:24 -0400 Date: Mon, 26 Mar 2012 14:48:16 +0200 From: Alon Levy Message-ID: <20120326124816.GB32389@garlic> References: <1332763670-32063-1-git-send-email-stefanha@linux.vnet.ibm.com> <1332763670-32063-6-git-send-email-stefanha@linux.vnet.ibm.com> <4F7063F3.4070906@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <4F7063F3.4070906@suse.de> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 5/5] trace-events: Fix broken build caused by wrong format specifier List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: Stefan Weil , Anthony Liguori , Stefan Hajnoczi , qemu-devel@nongnu.org On Mon, Mar 26, 2012 at 02:41:23PM +0200, Andreas F=E4rber wrote: > Am 26.03.2012 14:07, schrieb Stefan Hajnoczi: > > From: Stefan Weil > >=20 > > mem is an uint64_t value, so %lx was wrong. > >=20 > > Signed-off-by: Stefan Weil >=20 > Alon, you replied with an "ACK". Should an Acked-by be inserted here? Yes, should have been verbose, sorry. But I don't think it matters much for this kind of small patch. >=20 > Andreas >=20 > > Signed-off-by: Stefan Hajnoczi > > --- > > trace-events | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > >=20 > > diff --git a/trace-events b/trace-events > > index 70f059d..db2cd39 100644 > > --- a/trace-events > > +++ b/trace-events > > @@ -726,7 +726,7 @@ ppm_save(const char *filename, void *display_surf= ace) "%s surface=3D%p" > > # hw/qxl.c > > disable qxl_interface_set_mm_time(int qid, uint32_t mm_time) "%d %d" > > disable qxl_io_write_vga(int qid, const char *mode, uint32_t addr, u= int32_t val) "%d %s addr=3D%u val=3D%u" > > -qxl_create_guest_primary(int qid, uint32_t width, uint32_t height, u= int64_t mem, uint32_t format, uint32_t position) "%d %dx%d mem=3D%lx %d,%= d" > > +qxl_create_guest_primary(int qid, uint32_t width, uint32_t height, u= int64_t mem, uint32_t format, uint32_t position) "%d %ux%u mem=3D%" PRIx6= 4 " %u,%u" > > qxl_create_guest_primary_rest(int qid, int32_t stride, uint32_t type= , uint32_t flags) "%d %d,%d,%d" > > qxl_destroy_primary(int qid) "%d" > > qxl_enter_vga_mode(int qid) "%d" >=20 > --=20 > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrn= berg