From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52594) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCAjq-0003jp-Nh for qemu-devel@nongnu.org; Mon, 26 Mar 2012 10:17:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SCAjj-00051Z-Di for qemu-devel@nongnu.org; Mon, 26 Mar 2012 10:17:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27700) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCAjj-00051H-5g for qemu-devel@nongnu.org; Mon, 26 Mar 2012 10:17:31 -0400 Date: Mon, 26 Mar 2012 15:37:18 +0200 From: "Michael S. Tsirkin" Message-ID: <20120326133717.GC16511@redhat.com> References: <20120326094824.GA14504@redhat.com> <4F70428E.4070707@redhat.com> <20120326111942.GA15207@redhat.com> <4F706146.7040905@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F706146.7040905@redhat.com> Subject: Re: [Qemu-devel] console class in kvm List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Amit Shah , yan@daynix.com, qemu-devel@nongnu.org, kvm@vger.kernel.org On Mon, Mar 26, 2012 at 02:29:58PM +0200, Avi Kivity wrote: > On 03/26/2012 01:19 PM, Michael S. Tsirkin wrote: > > On Mon, Mar 26, 2012 at 12:18:54PM +0200, Avi Kivity wrote: > > > On 03/26/2012 11:48 AM, Michael S. Tsirkin wrote: > > > > kvm used to carry this commit: > > > > > > Used to? Which commit reverts this? > > > > A merge from qemu.git I would guess. > > git log does not seem to show the culprit, I don't know > > how to find it. > > It was e2478f504fff20ad (git log -SPCI_CLASS_OTHERS master -m -p). > > > > > > commit 4667e6ec0df770867095d8093562d93c94d96ca2 > > > > Author: Avi Kivity > > > > Date: Thu Feb 12 11:43:17 2009 +0200 > > > > > > > > Change virtio-console to PCI_CLASS_OTHERS > > > > > > > > As a PCI_CLASS_DISPLAY_OTHER, it reduces primary display somehow on Windows XP > > > > (possibly Windows disables acceleration since it fails to find a driver). > > > > > > > > Signed-off-by: Avi Kivity > > > > > > > > This seems to have been dropped. Is the issue gone? > > > > Could relevant parties speak up please? > > > > Do we want to merge this commit into qemu.git? > > > > > > It's an impossible compatibility problem now. I have this sinking > > > feeling that we need to create yet another driver property. > > > > That's easy, we have a class property for this already. > > Yes, d6beee9938. Exactly. qemu-kvm used to set the class to CLASS_OTHER while the current code sets it to PCI_CLASS_COMMUNICATION_OTHER. Do we want support for CLASS_OTHER or is it ok to drop it? > > -- > error compiling committee.c: too many arguments to function