Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command

[Michael Roth <mdroth@linux.vnet.ibm.com>]

On Mon, Mar 26, 2012 at 09:55:15AM -0500, Anthony Liguori wrote:
> On 03/26/2012 09:53 AM, Michael Roth wrote:
> >On Mon, Mar 26, 2012 at 11:28:01AM +0200, Michal Privoznik wrote:
> >>On 25.03.2012 03:19, Brad Smith wrote:
> >>>On 20/03/12 9:28 AM, Brad Smith wrote:
> >>>>On 20/03/12 6:14 AM, Michal Privoznik wrote:
> >>>>>On 18.03.2012 02:09, Brad Smith wrote:
> >>>>>>Michal,
> >>>>>>
> >>>>>>http://git.qemu.org/?p=qemu.git;a=commit;h=3424fc9f16a1e7d1c48eb6d605eb0ca63e199ec2
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>This broke the build. Un-break the tree.
> >>>>>>
> >>>>>
> >>>>>
> >>>>>Can you please be more specific? It works for me so I don't have a clue
> >>>>>what are you referring to. I mean, what compiler do you use, what errors
> >>>>>are thrown, etc.
> >>>>>
> >>>>>Michal
> >>>>
> >>>>The patch commited is full of Linux specific code.
> >>>
> >>>This is *STILL BROKEN*. If you can't get a fix in in a timely manner
> >>>then REVERT
> >>>the broken commit.
> >>>
> >>
> >>Brad,
> >>
> >>that's because the fix hasn't been merged yet. If you need fix very
> >>quickly you can apply this patch:
> >>
> >>http://lists.nongnu.org/archive/html/qemu-devel/2012-03/msg04054.html
> >
> >That one also requires your previous patch, and misses some things Luiz
> >caught. This is the latest one, Brad is CC'd:
> >
> >http://www.mail-archive.com/qemu-devel@nongnu.org/msg104240.html
> 
> Mike,
> 
> Can you send a PULL request?

Yup, I can't confirm the BSD fix atm though, only that it doesn't break builds
on linux/w32. Send anyway or wait for confirmation?

> 
> Regards,
> 
> Anthony Liguori
> 
> >
> >>
> >>Michal
> >>
> >
>