From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34837)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <serge@mail.hallyn.com>) id 1SCFh2-0004ip-NM
	for qemu-devel@nongnu.org; Mon, 26 Mar 2012 15:35:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <serge@mail.hallyn.com>) id 1SCFh0-0001z9-Mk
	for qemu-devel@nongnu.org; Mon, 26 Mar 2012 15:35:04 -0400
Received: from 50-56-35-84.static.cloud-ips.com ([50.56.35.84]:48337
	helo=mail.hallyn.com) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <serge@mail.hallyn.com>) id 1SCFh0-0001vH-IS
	for qemu-devel@nongnu.org; Mon, 26 Mar 2012 15:35:02 -0400
Date: Mon, 26 Mar 2012 19:35:18 +0000
From: "Serge E. Hallyn" <serge@hallyn.com>
Message-ID: <20120326193518.GB30266@mail.hallyn.com>
References: <20120326151340.GA25460@mail.hallyn.com>
	<op.wbsjlej8v638fp@l311563.la.gr.repsolypf.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <op.wbsjlej8v638fp@l311563.la.gr.repsolypf.com>
Subject: Re: [Qemu-devel] [PATCH 1/1] If user doesn't specify a uuid,
 generate a random one
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Brian Jackson <iggy@theiggy.com>
Cc: qemu-devel@nongnu.org, "Serge E. Hallyn" <serge@hallyn.com>

Quoting Brian Jackson (iggy@theiggy.com):
> On Mon, 26 Mar 2012 10:13:40 -0500, Serge E. Hallyn
> <serge@hallyn.com> wrote:
> 
> >Currently, if the user doesn't pass a uuid, the system uuid is set to
> >all zeros.  This patch generates a random one instead.
> >
> >Is there a reason to prefer all zeros?  If not, can a patch like this
> >one be applied?
> >
> >Signed-off-by: Serge Hallyn <serge.hallyn@canonical.com>
> >---
> > vl.c |   11 +++++++++++
> > 1 files changed, 11 insertions(+), 0 deletions(-)
> >
> >diff --git a/vl.c b/vl.c
> >index 112b0e0..2b53b62 100644
> >--- a/vl.c
> >+++ b/vl.c
> >@@ -247,7 +247,9 @@ int nb_numa_nodes;
> > uint64_t node_mem[MAX_NODES];
> > uint64_t node_cpumask[MAX_NODES];
> >+#include <uuid/uuid.h>
> 
> 
> 
> This adds a hard dep on libuuid (prior to this it's optional and
> only impacts the vdi block driver).

Yup.  If that's a problem we can re-implement our own, if the
change in default behavior is acceptable.

> > uint8_t qemu_uuid[16];
> >+bool uuid_set = false;
> >static QEMUBootSetHandler *boot_set_handler;
> > static void *boot_set_opaque;
> >@@ -3030,6 +3032,7 @@ int main(int argc, char **argv, char **envp)
> >                             " Wrong format.\n");
> >                     exit(1);
> >                 }
> >+                uuid_set = true;
> >                 break;
> > 	    case QEMU_OPTION_option_rom:
> > 		if (nb_option_roms >= MAX_OPTION_ROMS) {
> >@@ -3200,6 +3203,14 @@ int main(int argc, char **argv, char **envp)
> >         exit(0);
> >     }
> >+    if (!uuid_set) {
> >+        uuid_t uuid;
> >+        uuid_generate(uuid);
> >+        for (i = 0; i < 16; i++) {
> >+            qemu_uuid[i] = uuid[i];
> >+        }
> >+    }
> >+
> >     /* Open the logfile at this point, if necessary. We can't
> >open the logfile
> >      * when encountering either of the logging options (-d or -D)
> >because the
> >      * other one may be encountered later on the command line,
> >changing the