From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54893) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCUO3-0000SI-M3 for qemu-devel@nongnu.org; Tue, 27 Mar 2012 07:16:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SCUNw-00066l-9Y for qemu-devel@nongnu.org; Tue, 27 Mar 2012 07:16:27 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:57713) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCUNw-00066b-0d for qemu-devel@nongnu.org; Tue, 27 Mar 2012 07:16:20 -0400 Received: by wibhn6 with SMTP id hn6so4872569wib.10 for ; Tue, 27 Mar 2012 04:16:18 -0700 (PDT) Date: Tue, 27 Mar 2012 08:17:34 +0100 From: Stefan Hajnoczi Message-ID: <20120327071734.GD17933@stefanha-thinkpad.localdomain> References: <1332816143-4989-1-git-send-email-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1332816143-4989-1-git-send-email-david@gibson.dropbear.id.au> Subject: Re: [Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_io List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: kwolf@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, mst@redhat.com On Tue, Mar 27, 2012 at 01:42:23PM +1100, David Gibson wrote: > Currently dma_bdrv_io() takes a 'to_dev' boolean parameter to > determine the direction of DMA it is emulating. We already have a > DMADirection enum designed specifically to encode DMA directions. > This patch uses it for dma_bdrv_io() as well. This involves removing > the DMADirection definition from the #ifdef it was inside, but since that > only existed to protect the definition of dma_addr_t from places where > config.h is not included, there wasn't any reason for it to be there in > the first place. > > Cc: Kevin Wolf > > Signed-off-by: David Gibson > --- > dma-helpers.c | 20 ++++++++++++-------- > dma.h | 12 ++++++------ > hw/ide/core.c | 3 ++- > hw/ide/macio.c | 3 ++- > 4 files changed, 22 insertions(+), 16 deletions(-) Reviewed-by: Stefan Hajnoczi