qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <dwg@au1.ibm.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, aliguori@us.ibm.com,
	qemu-ppc <qemu-ppc@nongnu.org>,
	"Andreas Färber" <afaerber@suse.de>,
	mst@redhat.com
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] Use DMADirection type for dma_bdrv_io
Date: Wed, 28 Mar 2012 02:14:53 +1100	[thread overview]
Message-ID: <20120327151453.GA9582@truffala.fritz.box> (raw)
In-Reply-To: <4F71D20D.4090505@redhat.com>

On Tue, Mar 27, 2012 at 04:43:25PM +0200, Kevin Wolf wrote:
> Am 27.03.2012 16:30, schrieb Andreas Färber:
> > Am 27.03.2012 04:42, schrieb David Gibson:
> >> Currently dma_bdrv_io() takes a 'to_dev' boolean parameter to
> >> determine the direction of DMA it is emulating.  We already have a
> >> DMADirection enum designed specifically to encode DMA directions.
> >> This patch uses it for dma_bdrv_io() as well.  This involves removing
> >> the DMADirection definition from the #ifdef it was inside, but since that
> >> only existed to protect the definition of dma_addr_t from places where
> >> config.h is not included, there wasn't any reason for it to be there in
> >> the first place.
> >>
> >> Cc: Kevin Wolf <kwolf@redhat.com>
> >>
> >> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> > 
> > Including for ppc macio in absence of Alex,
> > 
> > Reviewed-by: Andreas Färber <afaerber@suse.de>
> > 
> > (Expecting this to go through IDE/Kevin's tree.)
> 
> So this isn't part of another series any more?

There's still some stuff to work on in that series, but these early
patches from it are ready to go, so I thought I'd try to get them in
now.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

  reply	other threads:[~2012-03-27 23:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-27  2:42 [Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_io David Gibson
2012-03-27  7:17 ` Stefan Hajnoczi
2012-03-27 14:30 ` Andreas Färber
2012-03-27 14:43   ` Kevin Wolf
2012-03-27 15:14     ` David Gibson [this message]
2012-03-27 15:17     ` Andreas Färber
2012-03-27 15:23       ` Kevin Wolf
2012-03-28  0:42       ` [Qemu-devel] [Qemu-ppc] " David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120327151453.GA9582@truffala.fritz.box \
    --to=dwg@au1.ibm.com \
    --cc=afaerber@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=kwolf@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).