From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57496) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCgCk-0007eY-Kz for qemu-devel@nongnu.org; Tue, 27 Mar 2012 19:53:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SCgCi-000177-Nr for qemu-devel@nongnu.org; Tue, 27 Mar 2012 19:53:34 -0400 Received: from e23smtp04.au.ibm.com ([202.81.31.146]:49739) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCgCi-00016T-16 for qemu-devel@nongnu.org; Tue, 27 Mar 2012 19:53:32 -0400 Received: from /spool/local by e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 27 Mar 2012 23:35:44 +1000 Date: Wed, 28 Mar 2012 02:14:53 +1100 From: David Gibson Message-ID: <20120327151453.GA9582@truffala.fritz.box> References: <1332816143-4989-1-git-send-email-david@gibson.dropbear.id.au> <4F71CEF4.1020306@suse.de> <4F71D20D.4090505@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4F71D20D.4090505@redhat.com> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] Use DMADirection type for dma_bdrv_io List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, aliguori@us.ibm.com, qemu-ppc , Andreas =?iso-8859-1?Q?F=E4rber?= , mst@redhat.com On Tue, Mar 27, 2012 at 04:43:25PM +0200, Kevin Wolf wrote: > Am 27.03.2012 16:30, schrieb Andreas Färber: > > Am 27.03.2012 04:42, schrieb David Gibson: > >> Currently dma_bdrv_io() takes a 'to_dev' boolean parameter to > >> determine the direction of DMA it is emulating. We already have a > >> DMADirection enum designed specifically to encode DMA directions. > >> This patch uses it for dma_bdrv_io() as well. This involves removing > >> the DMADirection definition from the #ifdef it was inside, but since that > >> only existed to protect the definition of dma_addr_t from places where > >> config.h is not included, there wasn't any reason for it to be there in > >> the first place. > >> > >> Cc: Kevin Wolf > >> > >> Signed-off-by: David Gibson > > > > Including for ppc macio in absence of Alex, > > > > Reviewed-by: Andreas Färber > > > > (Expecting this to go through IDE/Kevin's tree.) > > So this isn't part of another series any more? There's still some stuff to work on in that series, but these early patches from it are ready to go, so I thought I'd try to get them in now. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson