From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54988) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCh2r-0003uU-Nd for qemu-devel@nongnu.org; Tue, 27 Mar 2012 20:47:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SCh2p-0002xH-Jv for qemu-devel@nongnu.org; Tue, 27 Mar 2012 20:47:25 -0400 Received: from e23smtp01.au.ibm.com ([202.81.31.143]:56916) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCh2p-0002ws-1i for qemu-devel@nongnu.org; Tue, 27 Mar 2012 20:47:23 -0400 Received: from /spool/local by e23smtp01.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 28 Mar 2012 00:39:56 +1000 Date: Wed, 28 Mar 2012 11:42:35 +1100 From: David Gibson Message-ID: <20120328004235.GB9582@truffala.fritz.box> References: <1332816143-4989-1-git-send-email-david@gibson.dropbear.id.au> <4F71CEF4.1020306@suse.de> <4F71D20D.4090505@redhat.com> <4F71DA03.7050500@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4F71DA03.7050500@suse.de> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] Use DMADirection type for dma_bdrv_io List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: Kevin Wolf , aliguori@us.ibm.com, qemu-ppc , qemu-devel@nongnu.org, mst@redhat.com On Tue, Mar 27, 2012 at 05:17:23PM +0200, Andreas Färber wrote: > Am 27.03.2012 16:43, schrieb Kevin Wolf: > > Am 27.03.2012 16:30, schrieb Andreas Färber: > >> Am 27.03.2012 04:42, schrieb David Gibson: > >>> Currently dma_bdrv_io() takes a 'to_dev' boolean parameter to > >>> determine the direction of DMA it is emulating. We already have a > >>> DMADirection enum designed specifically to encode DMA directions. > >>> This patch uses it for dma_bdrv_io() as well. This involves removing > >>> the DMADirection definition from the #ifdef it was inside, but since that > >>> only existed to protect the definition of dma_addr_t from places where > >>> config.h is not included, there wasn't any reason for it to be there in > >>> the first place. > >>> > >>> Cc: Kevin Wolf > >>> > >>> Signed-off-by: David Gibson > >> > >> Including for ppc macio in absence of Alex, > >> > >> Reviewed-by: Andreas Färber > >> > >> (Expecting this to go through IDE/Kevin's tree.) > > > > So this isn't part of another series any more? > > AFAICS it's a single patch on qemu-devel, split out of one of the > "Various fixes David has piled up" series on Alex' suggestion. Actually in this case split out from "patches for IOMMU support" rather than one of the various fixes series. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson