From: Jason Wang <jasowang@redhat.com>
To: aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com,
quintela@redhat.com, rusty@rustcorp.com.au,
qemu-devel@nongnu.org, mst@redhat.com, pbonzini@redhat.com
Subject: [Qemu-devel] [V6 PATCH 2/4] net: model specific announcing support
Date: Wed, 28 Mar 2012 13:40:21 +0800 [thread overview]
Message-ID: <20120328054021.34135.47880.stgit@amd-6168-8-1.englab.nay.redhat.com> (raw)
In-Reply-To: <20120328053356.34135.42669.stgit@amd-6168-8-1.englab.nay.redhat.com>
This patch introduces a function pointer in NetClientInfo which is
called during self announcement. With this, each kind of card can
announce the link with a specific way. The old method is still kept
for cards that have not implemented this or old guest. The first user
would be virtio-net.
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
net.h | 2 ++
savevm.c | 8 +++++---
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/net.h b/net.h
index 75a8c15..7195bfc 100644
--- a/net.h
+++ b/net.h
@@ -48,6 +48,7 @@ typedef ssize_t (NetReceive)(VLANClientState *, const uint8_t *, size_t);
typedef ssize_t (NetReceiveIOV)(VLANClientState *, const struct iovec *, int);
typedef void (NetCleanup) (VLANClientState *);
typedef void (LinkStatusChanged)(VLANClientState *);
+typedef int (NetAnnounce)(VLANClientState *);
typedef struct NetClientInfo {
net_client_type type;
@@ -59,6 +60,7 @@ typedef struct NetClientInfo {
NetCleanup *cleanup;
LinkStatusChanged *link_status_changed;
NetPoll *poll;
+ NetAnnounce *announce;
} NetClientInfo;
struct VLANClientState {
diff --git a/savevm.c b/savevm.c
index 80be1ff..7558c1d 100644
--- a/savevm.c
+++ b/savevm.c
@@ -123,10 +123,12 @@ static void qemu_announce_self_iter(NICState *nic, void *opaque)
{
uint8_t buf[60];
int len;
+ NetAnnounce *func = nic->nc.info->announce;
- len = announce_self_create(buf, nic->conf->macaddr.a);
-
- qemu_send_packet_raw(&nic->nc, buf, len);
+ if (!func || func(&nic->nc) != 0) {
+ len = announce_self_create(buf, nic->conf->macaddr.a);
+ qemu_send_packet_raw(&nic->nc, buf, len);
+ }
}
next prev parent reply other threads:[~2012-03-28 5:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-28 5:40 [Qemu-devel] [V6 PATCH 0/4] Send gratuitous packets by guest Jason Wang
2012-03-28 5:40 ` [Qemu-devel] [V6 PATCH 1/4] net: announce self after vm start Jason Wang
2012-03-28 7:22 ` Paolo Bonzini
2012-05-02 7:49 ` Orit Wasserman
2012-05-02 7:59 ` Jason Wang
2012-05-02 8:32 ` Paolo Bonzini
2012-03-28 5:40 ` Jason Wang [this message]
2012-03-28 7:23 ` [Qemu-devel] [V6 PATCH 2/4] net: model specific announcing support Paolo Bonzini
2012-03-28 5:40 ` [Qemu-devel] [V6 PATCH 3/4] virtio-net: notify guest to annouce itself Jason Wang
2012-03-28 5:40 ` [Qemu-devel] [V6 PATCH 4/4] virtio-net: compat guest announce support Jason Wang
2012-05-02 3:51 ` [Qemu-devel] [V6 PATCH 0/4] Send gratuitous packets by guest Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120328054021.34135.47880.stgit@amd-6168-8-1.englab.nay.redhat.com \
--to=jasowang@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).