From: Alon Levy <alevy@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: "Lluís Vilanova" <vilanova@ac.upc.edu>,
stefanha@linux.vnet.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH trivial] trace-events: don't use dtrace reserved words in and next
Date: Wed, 28 Mar 2012 15:16:34 +0200 [thread overview]
Message-ID: <20120328131634.GY32389@garlic> (raw)
In-Reply-To: <CAJSP0QVtOV0aN+i3Ch_3fcKMAhjUww1_BEm9OtMRWXSG_2OqpA@mail.gmail.com>
On Wed, Mar 28, 2012 at 01:55:49PM +0100, Stefan Hajnoczi wrote:
> On Wed, Mar 28, 2012 at 8:55 AM, Alon Levy <alevy@redhat.com> wrote:
> > ---
> > trace-events | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> We're always going to struggle with new trace events that add reserved
> keywords. Fixing up trace-events is going to be an ongoing task so
> I'd like to also see tracetool automatically modify keywords 'next' ->
> 'next_'. Do you want to send a patch to do that instead?
sure. For the new tracetool.py too ? :)
>
> Stefan
>
next prev parent reply other threads:[~2012-03-28 13:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-28 7:55 [Qemu-devel] [PATCH trivial] trace-events: don't use dtrace reserved words in and next Alon Levy
2012-03-28 12:55 ` Stefan Hajnoczi
2012-03-28 13:16 ` Alon Levy [this message]
2012-03-28 13:33 ` Alon Levy
2012-03-28 13:35 ` Stefan Hajnoczi
2012-03-28 14:26 ` [Qemu-devel] [PATCH 1/2] tracetool: dtrace: handle in and next reserved words Alon Levy
2012-03-28 14:26 ` [Qemu-devel] [PATCH 2/2] tracetool: dtrace: warn on reserved word usage Alon Levy
2012-03-28 16:26 ` [Qemu-devel] [PATCH 1/2] tracetool: dtrace: handle in and next reserved words Lee Essen
2012-03-28 16:38 ` Eric Blake
2012-03-28 16:43 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120328131634.GY32389@garlic \
--to=alevy@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@linux.vnet.ibm.com \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).