From: David Gibson <david@gibson.dropbear.id.au>
To: "Andreas Färber" <afaerber@suse.de>
Cc: scottwood@freescale.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] pseries: Implement RTAS system-reboot call
Date: Thu, 29 Mar 2012 08:39:24 +1100 [thread overview]
Message-ID: <20120328213924.GA9582@truffala.fritz.box> (raw)
In-Reply-To: <4F733916.5010104@suse.de>
On Wed, Mar 28, 2012 at 06:15:18PM +0200, Andreas Färber wrote:
> Am 28.03.2012 03:05, schrieb David Gibson:
> > This patch adds the PAPR defined RTAS system-reboot call to the pseries
> > machine emulation, providing the guest with a way to trigger a reboot.
> > This exposes a bug in the pseries VIO code which means CRQs are not
> > properly reset on a system reset. This patch also fixes that bug by
> > adding a suitable reset handler.
> >
> > Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
>
> Patch overall looks good to me, except for some minor things.
Ok. Comments folded in and resent.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
prev parent reply other threads:[~2012-03-28 23:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-28 1:05 [Qemu-devel] [PATCH] pseries: Implement RTAS system-reboot call David Gibson
2012-03-28 16:15 ` Andreas Färber
2012-03-28 21:39 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120328213924.GA9582@truffala.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=afaerber@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).