From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33978) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SD2c7-00050K-OO for qemu-devel@nongnu.org; Wed, 28 Mar 2012 19:49:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SD0b1-0004aV-Du for qemu-devel@nongnu.org; Wed, 28 Mar 2012 17:40:03 -0400 Date: Thu, 29 Mar 2012 08:39:24 +1100 From: David Gibson Message-ID: <20120328213924.GA9582@truffala.fritz.box> References: <1332896731-25957-1-git-send-email-david@gibson.dropbear.id.au> <4F733916.5010104@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <4F733916.5010104@suse.de> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] pseries: Implement RTAS system-reboot call List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: scottwood@freescale.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org On Wed, Mar 28, 2012 at 06:15:18PM +0200, Andreas F=E4rber wrote: > Am 28.03.2012 03:05, schrieb David Gibson: > > This patch adds the PAPR defined RTAS system-reboot call to the pseri= es > > machine emulation, providing the guest with a way to trigger a reboot= . > > This exposes a bug in the pseries VIO code which means CRQs are not > > properly reset on a system reset. This patch also fixes that bug by > > adding a suitable reset handler. > >=20 > > Signed-off-by: David Gibson >=20 > Patch overall looks good to me, except for some minor things. Ok. Comments folded in and resent. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other= _ | _way_ _around_! http://www.ozlabs.org/~dgibson