From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33665) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SD2bW-0004dP-VM for qemu-devel@nongnu.org; Wed, 28 Mar 2012 19:48:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SD13E-00046K-Cr for qemu-devel@nongnu.org; Wed, 28 Mar 2012 18:09:09 -0400 Received: from mail-gy0-f173.google.com ([209.85.160.173]:42645) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SD13E-000466-6V for qemu-devel@nongnu.org; Wed, 28 Mar 2012 18:09:08 -0400 Received: by ghrr14 with SMTP id r14so1407308ghr.4 for ; Wed, 28 Mar 2012 15:09:06 -0700 (PDT) Sender: fluxion Date: Wed, 28 Mar 2012 17:08:59 -0500 From: Michael Roth Message-ID: <20120328220859.GA10826@illuin> References: <1332418064-23091-1-git-send-email-kraxel@redhat.com> <4F6B30A8.6060903@suse.de> <4F6B3933.20708@redhat.com> <4F6B414C.6070206@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4F6B414C.6070206@suse.de> Subject: Re: [Qemu-devel] [PATCH] usb/vmstate: add parent dev path List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: Paolo Bonzini , Gerd Hoffmann , Anthony Liguori , qemu-devel@nongnu.org On Thu, Mar 22, 2012 at 04:12:12PM +0100, Andreas Färber wrote: > Am 22.03.2012 15:37, schrieb Gerd Hoffmann: > >>> + .driver = "USB", > >>> + .property = "full-path", > >>> + .value = "no", > >> > >> This touches on our "favorite" bit/bool topic again. While I agree that > >> "no" makes sense for a property of that name, the current code still > >> expects "on" and "off". In particular, "yes" would not work as expected. > > > > "no" *does* work as expected though, at least it survived my tests, > > thats why I didn't notice. > > > > I can s/no/off/ for consistency, no problem. Merging your yes/no patch > > is fine with me too. > > I stand corrected: Michael Roth's conversion of qdev properties to use > visitors implicitly changed the parsing logic to cover yes/no and > true/false as well. That's great news! I believe Paolo did that conversion, but agreed :) > > So no change of .value is needed here. The only thing to note is that > print_bit() will output the value as on/off. > > Sorry for the confusion, > > Andreas > > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg >