From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58047) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDRrq-0001Dc-7P for qemu-devel@nongnu.org; Thu, 29 Mar 2012 22:47:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SDRrm-0006c6-Sz for qemu-devel@nongnu.org; Thu, 29 Mar 2012 22:47:09 -0400 Received: from e23smtp07.au.ibm.com ([202.81.31.140]:46117) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDRrm-0006Yb-98 for qemu-devel@nongnu.org; Thu, 29 Mar 2012 22:47:06 -0400 Received: from /spool/local by e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 30 Mar 2012 02:40:34 +1000 Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q2U2eE4f3551378 for ; Fri, 30 Mar 2012 13:40:24 +1100 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q2U2kPmt031062 for ; Fri, 30 Mar 2012 13:46:25 +1100 Date: Fri, 30 Mar 2012 13:46:10 +1100 From: David Gibson Message-ID: <20120330024610.GF7015@truffala.fritz.box> References: <1332816201-5072-1-git-send-email-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1332816201-5072-1-git-send-email-david@gibson.dropbear.id.au> Subject: Re: [Qemu-devel] [PATCH] Better support for dma_addr_t variables List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: aliguori@us.ibm.com Cc: qemu-devel@nongnu.org, mst@redhat.com Uh.. please apply? Anyone? On Tue, Mar 27, 2012 at 01:43:21PM +1100, David Gibson wrote: > A while back, we introduced the dma_addr_t type, which is supposed to > be used for bus visible memory addresses. At present, this is an > alias for target_phys_addr_t, but this will change when we eventually > add support for guest visible IOMMUs. > > There are some instances of target_phys_addr_t in the code now which > should really be dma_addr_t, but can't be trivially converted due to > missing features which this patch corrects. > > * We add DMA_ADDR_BITS analagous to TARGET_PHYS_ADDR_BITS. This is > important where we need to make a compile-time (#if) based on the > size of dma_addr_t. > > * We add a new helper macro to create device properties which take a > dma_addr_t, currently an alias to DEFINE_PROP_TADDR(). > > Signed-off-by: David Gibson > --- > dma.h | 1 + > hw/qdev-dma.h | 4 ++++ > 2 files changed, 5 insertions(+), 0 deletions(-) > create mode 100644 hw/qdev-dma.h > > diff --git a/dma.h b/dma.h > index 05ac325..463095c 100644 > --- a/dma.h > +++ b/dma.h > @@ -32,6 +32,7 @@ struct QEMUSGList { > #if defined(TARGET_PHYS_ADDR_BITS) > typedef target_phys_addr_t dma_addr_t; > > +#define DMA_ADDR_BITS TARGET_PHYS_ADDR_BITS > #define DMA_ADDR_FMT TARGET_FMT_plx > > struct ScatterGatherEntry { > diff --git a/hw/qdev-dma.h b/hw/qdev-dma.h > new file mode 100644 > index 0000000..e407771 > --- /dev/null > +++ b/hw/qdev-dma.h > @@ -0,0 +1,4 @@ > +#include "qdev-addr.h" > + > +#define DEFINE_PROP_DMAADDR(_n, _s, _f, _d) \ > + DEFINE_PROP_TADDR(_n, _s, _f, _d) -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson