* [Qemu-devel] RFC: options parsing in vl.c should be module
@ 2012-03-30 6:52 Wanpeng Li
0 siblings, 0 replies; 2+ messages in thread
From: Wanpeng Li @ 2012-03-30 6:52 UTC (permalink / raw)
To: qemu-devel
Hi all:
Consider of the options parsing process in main function of vl.c is too long.
It should be module into single function to clear Ideas, strengthen the source code
management, and increase code readability.
Regards,
Wanpeng Li
--
LTC China, IBM, Shanghai
^ permalink raw reply [flat|nested] 2+ messages in thread
[parent not found: <4f75589c.120db50a.61e2.0bc0SMTPIN_ADDED@mx.google.com>]
* Re: [Qemu-devel] RFC: options parsing in vl.c should be module
[not found] <4f75589c.120db50a.61e2.0bc0SMTPIN_ADDED@mx.google.com>
@ 2012-03-30 10:34 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2012-03-30 10:34 UTC (permalink / raw)
To: Wanpeng Li; +Cc: qemu-devel
On Fri, Mar 30, 2012 at 7:52 AM, Wanpeng Li <liwp@linux.vnet.ibm.com> wrote:
> Consider of the options parsing process in main function of vl.c is too long.
> It should be module into single function to clear Ideas, strengthen the source code
> management, and increase code readability.
I suggest sending a patch to show what you want to do.
In general you may find that pure refactoring patches don't receive as
much attention as patches that fix bugs or add features. As long as
your patch is focussed and clean it can probably get in. vl.c:main()
is ugly but we need to be very careful not to break existing
command-line invocations, so consider whether it's worth doing this
and how you will test it.
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-30 10:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-30 6:52 [Qemu-devel] RFC: options parsing in vl.c should be module Wanpeng Li
[not found] <4f75589c.120db50a.61e2.0bc0SMTPIN_ADDED@mx.google.com>
2012-03-30 10:34 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).