qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: armbru@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org,
	stefanha@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH v2 0/2]: convert device_del to the qapi
Date: Fri, 30 Mar 2012 08:22:00 +0100	[thread overview]
Message-ID: <20120330072200.GC16159@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <1333040202-11225-1-git-send-email-lcapitulino@redhat.com>

On Thu, Mar 29, 2012 at 01:56:40PM -0300, Luiz Capitulino wrote:
> V2:
> 
> o change qdev_unplug() to return void (this allows some simplifications)
> o rename pci_device_hot_remove() 'errp' var to 'local_err'
> o minor changelog fixes
> 
>  hmp-commands.hx      |    3 +--
>  hmp.c                |    9 +++++++++
>  hmp.h                |    1 +
>  hw/pci-hotplug.c     |   14 ++++++++++++--
>  hw/qdev-monitor.c    |   11 ++++++-----
>  hw/qdev.c            |   12 ++++++++----
>  hw/qdev.h            |    3 ++-
>  hw/usb/dev-storage.c |    2 +-
>  hw/xen_platform.c    |    4 ++--
>  qapi-schema.json     |   20 ++++++++++++++++++++
>  qmp-commands.hx      |    5 +----
>  11 files changed, 63 insertions(+), 21 deletions(-)
> 

Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

      parent reply	other threads:[~2012-03-30  8:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-29 16:56 [Qemu-devel] [PATCH v2 0/2]: convert device_del to the qapi Luiz Capitulino
2012-03-29 16:56 ` [Qemu-devel] [PATCH 1/2] qdev: qdev_unplug(): use error_set() Luiz Capitulino
2012-03-29 16:56 ` [Qemu-devel] [PATCH 2/2] qapi: convert device_del Luiz Capitulino
2012-03-29 17:55   ` Eric Blake
2012-03-30 13:10     ` Luiz Capitulino
2012-03-30  7:22 ` Stefan Hajnoczi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120330072200.GC16159@stefanha-thinkpad.localdomain \
    --to=stefanha@gmail.com \
    --cc=aliguori@us.ibm.com \
    --cc=armbru@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).