From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40636)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SDbSS-0002X9-3X
	for qemu-devel@nongnu.org; Fri, 30 Mar 2012 09:01:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SDbSI-0002gC-95
	for qemu-devel@nongnu.org; Fri, 30 Mar 2012 09:01:35 -0400
Received: from mx1.redhat.com ([209.132.183.28]:19156)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SDbSI-0002g1-0x
	for qemu-devel@nongnu.org; Fri, 30 Mar 2012 09:01:26 -0400
Date: Fri, 30 Mar 2012 10:01:27 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120330100127.61b21e5d@doriath.home>
In-Reply-To: <4F756580.404@redhat.com>
References: <1333042003-15490-1-git-send-email-lcapitulino@redhat.com>
	<1333042003-15490-13-git-send-email-lcapitulino@redhat.com>
	<4F74A95A.7050403@us.ibm.com> <20120329192813.GA14158@illuin>
	<4F74BF8C.3070800@us.ibm.com> <4F756580.404@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 12/13] qapi: support for keyworded
 variable-length argument list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, stefanha@linux.vnet.ibm.com, armbru@redhat.com, qemu-devel@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>, kraxel@redhat.com

On Fri, 30 Mar 2012 09:49:20 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> Regarding device_add ? and device_add foo,? I would implement it as
> separate QMP commands hooking into QOM, such as qom_list_types (taking
> the superclass as an optional argument) and qom_properties.  But the
> latter first needs static properties to move up from devices to objects.

Yes, after I suggested query-devices I remembered about qom_list_types.

I think it's ok for hmp.c to use it even if it's not declared stable yet,
right?

Anthony, you said you did it in your tree differently, did you? I think
using qom_list_types is the way to go here...