From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46773) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDhS3-0001i2-7F for qemu-devel@nongnu.org; Fri, 30 Mar 2012 15:25:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SDhS1-0007kr-EN for qemu-devel@nongnu.org; Fri, 30 Mar 2012 15:25:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24313) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SDhS1-0007km-58 for qemu-devel@nongnu.org; Fri, 30 Mar 2012 15:25:33 -0400 Date: Fri, 30 Mar 2012 22:25:25 +0300 From: Alon Levy Message-ID: <20120330192525.GA11611@garlic.home> References: <1332771332-14090-1-git-send-email-alevy@redhat.com> <1333056194-24426-1-git-send-email-alevy@redhat.com> <4F756B08.1080700@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F756B08.1080700@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3] spice_info: add mouse_mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org, anthony@codemonkey.ws On Fri, Mar 30, 2012 at 10:12:56AM +0200, Gerd Hoffmann wrote: > Hi, > > > +# @SpiceQueryMouseMode > > +# > > +# An enumation of Spice mouse states. > > +# > > +# @client: Mouse cursor position is determined by the client. > > +# > > +# @server: Mouse cursor position is determined by the server. > > +# > > +# @unknown: No information is available about mouse mode used by > > +# the spice server. > > +# > > +# Note: spice/enums.h has a SpiceMouseMode already, hence the name. > > I guess it makes sense then to just add "unknown" to the existing > SpiceMouseMode and reuse it ... But then you don't get the nifty autogenerated lookup table, although I agree having two enums is bound to cause confusion somehow. I could just code a lookup table for the hmp. > > cheers, > Gerd >