From: Olaf Hering <olaf@aepfle.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: xen-devel@lists.xensource.com, "Erik Blake" <eblake@redhat.com>,
"Andreas Färber" <afaerber@suse.de>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu/configure: fix CFLAGS handling for i386
Date: Sat, 31 Mar 2012 18:55:24 +0200 [thread overview]
Message-ID: <20120331165524.GA26203@aepfle.de> (raw)
In-Reply-To: <CAFEAcA9HOS75B_SdocuWENaKtgghDVrXNAZDVTJJf7Vs_AB+1Q@mail.gmail.com>
On Sat, Mar 31, Peter Maydell wrote:
> On 31 March 2012 16:41, Andreas Färber <afaerber@suse.de> wrote:
> > This is the only usage of += outside Makefile fragments, so I wonder if
> > its use may have been by accident. Is it safe in a POSIX context?
> > Or should we better use CFLAGS="$CFLAGS -march=486"?
> > For QEMU_CFLAGS we use the pattern QEMU_CFLAGS="-options $QEMU_CFLAGS"
> > to allow overriding options.
>
> For that matter, should this be setting QEMU_CFLAGS instead of
> CFLAGS? I have to say I'm not entirely sure what the difference
> is...
I havent looked into qemu build internals, but there is most likely a
concept of HOST_TOOLS_CFLAGS and TARGET_CFLAGS in qemus Makefiles.
Olaf
prev parent reply other threads:[~2012-03-31 16:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 15:24 [Qemu-devel] [PATCH] qemu/configure: fix CFLAGS handling for i386 Olaf Hering
2012-03-31 15:41 ` Andreas Färber
2012-03-31 16:46 ` Olaf Hering
2012-04-02 7:54 ` Andreas Färber
2012-03-31 16:52 ` Peter Maydell
2012-03-31 16:55 ` Olaf Hering [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120331165524.GA26203@aepfle.de \
--to=olaf@aepfle.de \
--cc=afaerber@suse.de \
--cc=eblake@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).