From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51280) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SEJpn-00031a-Or for qemu-devel@nongnu.org; Sun, 01 Apr 2012 08:24:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SEJpk-0002HU-1y for qemu-devel@nongnu.org; Sun, 01 Apr 2012 08:24:39 -0400 Received: from e23smtp06.au.ibm.com ([202.81.31.148]:41212) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SEJpj-0002HF-Gd for qemu-devel@nongnu.org; Sun, 01 Apr 2012 08:24:35 -0400 Received: from /spool/local by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 1 Apr 2012 12:19:36 +1000 Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q31CHuPQ3449026 for ; Sun, 1 Apr 2012 22:17:56 +1000 Received: from d23av04.au.ibm.com (loopback [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q31COAT9025622 for ; Sun, 1 Apr 2012 22:24:10 +1000 Date: Sun, 1 Apr 2012 19:21:00 +1000 From: David Gibson Message-ID: <20120401092100.GA26217@truffala.fritz.box> References: <1332816201-5072-1-git-send-email-david@gibson.dropbear.id.au> <20120401091728.GC22071@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120401091728.GC22071@redhat.com> Subject: Re: [Qemu-devel] [PATCH] Better support for dma_addr_t variables List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org On Sun, Apr 01, 2012 at 12:17:28PM +0300, Michael S. Tsirkin wrote: > On Tue, Mar 27, 2012 at 01:43:21PM +1100, David Gibson wrote: > > A while back, we introduced the dma_addr_t type, which is supposed to > > be used for bus visible memory addresses. At present, this is an > > alias for target_phys_addr_t, but this will change when we eventually > > add support for guest visible IOMMUs. > > > > There are some instances of target_phys_addr_t in the code now which > > should really be dma_addr_t, but can't be trivially converted due to > > missing features which this patch corrects. > > > > * We add DMA_ADDR_BITS analagous to TARGET_PHYS_ADDR_BITS. This is > > important where we need to make a compile-time (#if) based on the > > size of dma_addr_t. > > > > * We add a new helper macro to create device properties which take a > > dma_addr_t, currently an alias to DEFINE_PROP_TADDR(). > > > > Signed-off-by: David Gibson > > I don't have any issues with this but let's apply together > with the patch converting the devices that you mention. Ok, I'll resend as a two patch series with the xhci conversion, which is the main one. > > diff --git a/hw/qdev-dma.h b/hw/qdev-dma.h > > new file mode 100644 > > index 0000000..e407771 > > --- /dev/null > > +++ b/hw/qdev-dma.h > > @@ -0,0 +1,4 @@ > > +#include "qdev-addr.h" > > + > > +#define DEFINE_PROP_DMAADDR(_n, _s, _f, _d) \ > > + DEFINE_PROP_TADDR(_n, _s, _f, _d) > > Headers need preprocessor guards so that multiple > inclusions don't trigger errors. Again, a flaw copied from qdev-addr.h > It does not matter much but did you consider sticking this > in dma.h instead of adding a new header? I'm pretty sure I tried that and ran into some sort of hairy circular dependency problem which this seemed amongst the easier ways to work around. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson