From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:48949)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SEWQ3-0000h7-OD
	for qemu-devel@nongnu.org; Sun, 01 Apr 2012 21:50:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SEWQ1-0005Fk-Vp
	for qemu-devel@nongnu.org; Sun, 01 Apr 2012 21:50:55 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47410)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SEWQ1-0005FZ-NP
	for qemu-devel@nongnu.org; Sun, 01 Apr 2012 21:50:53 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q321ooU6009379
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Sun, 1 Apr 2012 21:50:50 -0400
Date: Sun, 1 Apr 2012 22:50:57 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120401225057.5c1e44da@doriath.home>
In-Reply-To: <1333191021-2189-1-git-send-email-pbonzini@redhat.com>
References: <1333191021-2189-1-git-send-email-pbonzini@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] tests: remove .SECONDARY special target
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

On Sat, 31 Mar 2012 12:50:21 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> The special target should not be needed anymore, and caused (perhaps
> due to a Make bug) a failure with "make -j2".  In any case, the
> main makefile is a better place for such special targets rather
> than an included makefile.
> 
> Reported-by: Luiz Capitulino <lcapitulino@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Tested-by: Luiz Capitulino <lcapitulino@redhat.com>

Nice to see it building again.

> ---
> 	Anthony, this was taken from your patches, do you remember
>         why it's needed?  I changed the rules to use the GNU Make
>         "LIST: TARGET-PATTERN: SOURCE-PATTERN" syntax so there
>         should be no implicit rules anymore and .SECONDARY should
>         not be needed.
> 
>  tests/Makefile |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/Makefile b/tests/Makefile
> index 17f6ece..25a972a 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -74,8 +74,6 @@ check-help:
>  	@echo "Default options are -k and (for make V=1) --verbose; they can be"
>  	@echo "changed with variable GTESTER_OPTIONS."
>  
> -.SECONDARY:
> -
>  SPEED = quick
>  GTESTER_OPTIONS = -k $(if $(V),--verbose,-q)
>