From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Lluís Vilanova" <vilanova@ac.upc.edu>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH v3 0/8] Rewrite tracetool using python modules
Date: Mon, 2 Apr 2012 08:39:50 +0100 [thread overview]
Message-ID: <20120402073950.GB19273@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <87zkayovw1.fsf@ginnungagap.bsc.es>
On Fri, Mar 30, 2012 at 07:12:46PM +0200, Lluís Vilanova wrote:
> Stefan Hajnoczi writes:
> > Only one point: please don't introduce PUBLIC yet. Let's add it when
> > it's needed. At the moment nothing uses it.
>
> > I have tested this series with all backends and looked at the diff
> > between the old tracetool and tracetool.py.
>
> > I'm happy with this series. We need to test it hard for 1.1 to make
> > sure there are no hickups for tracing users.
>
> Sure. I'll send v4 without the PUBLIC-related contents and turning "kwargs" into
> specific arguments.
>
> Once accepted, I'll send the first two batches of changes in my queue, which are
> orthogonal to instrumentation (basically tracing cleanups in both the build and
> the API).
>
> I suppose everyone prefers to wait until after the 1.1 release to start having a
> look at instrumentation (which I still have to port to this new tracetool).
Great. I'd like to merge the Python tracetool for 1.1. I've diffed the
generated code and it appears compatible with the shell tracetool
output. Therefore I'm pretty confident with this series.
Future series will not make it into 1.1 just because we're running out
of time to review and test.
Stefan
next prev parent reply other threads:[~2012-04-02 8:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 19:49 [Qemu-devel] [RFC PATCH v3 0/8] Rewrite tracetool using python modules Lluís Vilanova
2012-03-27 19:49 ` [Qemu-devel] [RFC PATCH v3 1/8] tracetool: Rewrite infrastructure as " Lluís Vilanova
2012-03-30 7:27 ` Stefan Hajnoczi
2012-03-30 16:55 ` Lluís Vilanova
2012-04-02 7:36 ` Stefan Hajnoczi
2012-04-02 12:57 ` Lluís Vilanova
2012-03-27 19:49 ` [Qemu-devel] [RFC PATCH v3 2/8] tracetool: Add module for the 'c' format Lluís Vilanova
2012-03-27 19:49 ` [Qemu-devel] [RFC PATCH v3 3/8] tracetool: Add module for the 'h' format Lluís Vilanova
2012-03-27 19:49 ` [Qemu-devel] [RFC PATCH v3 4/8] tracetool: Add support for the 'stderr' backend Lluís Vilanova
2012-03-27 19:49 ` [Qemu-devel] [RFC PATCH v3 5/8] tracetool: Add support for the 'simple' backend Lluís Vilanova
2012-03-27 19:49 ` [Qemu-devel] [RFC PATCH v3 6/8] tracetool: Add support for the 'ust' backend Lluís Vilanova
2012-03-27 19:49 ` [Qemu-devel] [RFC PATCH v3 7/8] tracetool: Add support for the 'dtrace' backend Lluís Vilanova
2012-03-27 19:49 ` [Qemu-devel] [RFC PATCH v3 8/8] tracetool: Add MAINTAINERS info Lluís Vilanova
2012-03-29 17:16 ` [Qemu-devel] [RFC PATCH v3 0/8] Rewrite tracetool using python modules Stefan Hajnoczi
2012-03-30 17:12 ` Lluís Vilanova
2012-04-02 7:39 ` Stefan Hajnoczi [this message]
2012-04-02 12:52 ` Lluís Vilanova
2012-04-02 13:16 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120402073950.GB19273@stefanha-thinkpad.localdomain \
--to=stefanha@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).