From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47802) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SEcc8-0003us-Ge for qemu-devel@nongnu.org; Mon, 02 Apr 2012 04:27:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SEcc6-0002jj-M4 for qemu-devel@nongnu.org; Mon, 02 Apr 2012 04:27:48 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:39550) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SEcc6-0002jC-D8 for qemu-devel@nongnu.org; Mon, 02 Apr 2012 04:27:46 -0400 Received: by wibhr17 with SMTP id hr17so2152232wib.10 for ; Mon, 02 Apr 2012 01:27:44 -0700 (PDT) Date: Mon, 2 Apr 2012 08:42:36 +0100 From: Stefan Hajnoczi Message-ID: <20120402074236.GC19273@stefanha-thinkpad.localdomain> References: <1333097427-20912-1-git-send-email-zwu.kernel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v3 2/2] block: disable I/O throttling on sync api List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhi Yong Wu Cc: kwolf@redhat.com, wuzhy@linux.vnet.ibm.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com On Sat, Mar 31, 2012 at 08:09:46PM +0800, Zhi Yong Wu wrote: > On Fri, Mar 30, 2012 at 6:29 PM, Stefan Hajnoczi wrote: > > On Fri, Mar 30, 2012 at 9:50 AM,   wrote: > >> +     * When all sync I/O drivers are converted to async I/O, it will be restored > >> +     * to the original state. > > > > The problem here is that guess_disk_lchs() uses bdrv_read(), not > > whether device emulation uses sync or async I/O.  Converting devices > > to async I/O will not fix this. > By the way, when you did testing, you applied #1 of this patchset? I > think that it make sense for that assert issue to be fixed. Yes, I applied both patches 1 and 2. Stefan