* [Qemu-devel] [PATCH] qtest: Add missing GCC_FMT_ATTR
@ 2012-03-31 15:11 Stefan Weil
2012-04-02 13:00 ` Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Weil @ 2012-03-31 15:11 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Stefan Weil
gcc reports an error when the code is compiled with -Wmissing-format-attribute.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
qtest.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/qtest.c b/qtest.c
index cd7186c..53e2ed6 100644
--- a/qtest.c
+++ b/qtest.c
@@ -156,7 +156,8 @@ static void qtest_send_prefix(CharDriverState *chr)
tv.tv_sec, tv.tv_usec);
}
-static void qtest_send(CharDriverState *chr, const char *fmt, ...)
+static void GCC_FMT_ATTR(2, 3) qtest_send(CharDriverState *chr,
+ const char *fmt, ...)
{
va_list ap;
char buffer[1024];
--
1.7.9
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] qtest: Add missing GCC_FMT_ATTR
2012-03-31 15:11 [Qemu-devel] [PATCH] qtest: Add missing GCC_FMT_ATTR Stefan Weil
@ 2012-04-02 13:00 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2012-04-02 13:00 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, qemu-devel
On Sat, Mar 31, 2012 at 05:11:31PM +0200, Stefan Weil wrote:
> gcc reports an error when the code is compiled with -Wmissing-format-attribute.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> qtest.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-02 13:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-31 15:11 [Qemu-devel] [PATCH] qtest: Add missing GCC_FMT_ATTR Stefan Weil
2012-04-02 13:00 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).