From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:50303)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1SEgwc-0000Em-Mg
	for qemu-devel@nongnu.org; Mon, 02 Apr 2012 09:05:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1SEgwX-0002Vh-Pr
	for qemu-devel@nongnu.org; Mon, 02 Apr 2012 09:05:14 -0400
Date: Mon, 2 Apr 2012 14:05:04 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20120402130504.GD11583@stefanha-thinkpad.localdomain>
References: <1333310850-28767-1-git-send-email-sw@weilnetz.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1333310850-28767-1-git-send-email-sw@weilnetz.de>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] qxl: Add missing
 GCC_FMT_ATTR and fix format specifier
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>

On Sun, Apr 01, 2012 at 10:07:30PM +0200, Stefan Weil wrote:
> val is an uint64_t, therefore %d was not correct.
> 
> Cc: Gerd Hoffmann <kraxel@redhat.com>

Waiting for Gerd's Ack.

> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  hw/qxl.c |    2 +-
>  hw/qxl.h |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/qxl.c b/hw/qxl.c
> index 47a162e..85028dd 100644
> --- a/hw/qxl.c
> +++ b/hw/qxl.c
> @@ -1370,7 +1370,7 @@ async_common:
>      case QXL_IO_DESTROY_SURFACE_WAIT:
>          if (val >= NUM_SURFACES) {
>              qxl_guest_bug(d, "QXL_IO_DESTROY_SURFACE (async=%d):"
> -                             "%d >= NUM_SURFACES", async, val);
> +                             "%" PRIu64 " >= NUM_SURFACES", async, val);
>              goto cancel_async;
>          }
>          qxl_spice_destroy_surface_wait(d, val, async);
> diff --git a/hw/qxl.h b/hw/qxl.h
> index 11a0db3..cbb1e2d 100644
> --- a/hw/qxl.h
> +++ b/hw/qxl.h
> @@ -127,7 +127,7 @@ typedef struct PCIQXLDevice {
>  
>  /* qxl.c */
>  void *qxl_phys2virt(PCIQXLDevice *qxl, QXLPHYSICAL phys, int group_id);
> -void qxl_guest_bug(PCIQXLDevice *qxl, const char *msg, ...);
> +void qxl_guest_bug(PCIQXLDevice *qxl, const char *msg, ...) GCC_FMT_ATTR(2, 3);
>  
>  void qxl_spice_update_area(PCIQXLDevice *qxl, uint32_t surface_id,
>                             struct QXLRect *area, struct QXLRect *dirty_rects,

For two unrelated fixes I would do separate commits but don't worry
about resending.

Stefan