From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56503)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1SEhof-0002mq-Jf
	for qemu-devel@nongnu.org; Mon, 02 Apr 2012 10:01:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1SEhoY-0001aZ-64
	for qemu-devel@nongnu.org; Mon, 02 Apr 2012 10:01:05 -0400
Received: from mx1.redhat.com ([209.132.183.28]:62776)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1SEhoX-0001aJ-UJ
	for qemu-devel@nongnu.org; Mon, 02 Apr 2012 10:00:58 -0400
Date: Mon, 2 Apr 2012 15:00:52 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20120402140052.GG19259@redhat.com>
References: <1333363816-1691-1-git-send-email-berrange@redhat.com>
	<1333363816-1691-4-git-send-email-berrange@redhat.com>
	<CAFEAcA-NOePQXroCSm62-8PcqV_s_+DEzw7myktGs5tAhQZN8Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAFEAcA-NOePQXroCSm62-8PcqV_s_+DEzw7myktGs5tAhQZN8Q@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 3/9] Print out progress when checking
 compiler flags
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org

On Mon, Apr 02, 2012 at 02:56:17PM +0100, Peter Maydell wrote:
> On 2 April 2012 11:50, Daniel P. Berrange <berrange@redhat.com> wrote:
> > From: "Daniel P. Berrange" <berrange@redhat.com>
> >
> > Normal practice for autoconf style scripts is to print out
> > progress. The QEMU configure script is getting increasingly
> > slow & has no progress feedback. Print out the progress of
> > checking each compiler flag
> >
> > Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> > ---
> > =C2=A0configure | =C2=A0 =C2=A04 ++++
> > =C2=A01 files changed, 4 insertions(+), 0 deletions(-)
> >
> > diff --git a/configure b/configure
> > index 64ab4dc..44b28c8 100755
> > --- a/configure
> > +++ b/configure
> > @@ -1170,8 +1170,12 @@ int main(void) { return 0; }
> > =C2=A0EOF
> > =C2=A0warning_flags=3D
> > =C2=A0for flag in $gcc_flags; do
> > + =C2=A0 =C2=A0echo -n "checking if $cc supports $flag... "
> > =C2=A0 =C2=A0 if compile_prog "-Werror $warning_flags $flag" "" ; the=
n
> > =C2=A0 =C2=A0 =C2=A0 =C2=A0warning_flags=3D"$warning_flags $flag"
> > + =C2=A0 =C2=A0 =C2=A0 echo "yes"
> > + =C2=A0 =C2=A0else
> > + =C2=A0 =C2=A0 =C2=A0 echo "no"
> > =C2=A0 =C2=A0 fi
> > =C2=A0done
> > =C2=A0QEMU_CFLAGS=3D"$QEMU_CFLAGS $warning_flags"
>=20
> If we're going to do this we should do it consistently,
> ie add messages for all tests, not just this one.
> (Bonus points for also adding messages to config.log so you
> can see which test compiles correspond to which feature tests.)

I did wonder about doing that. If people are generally for the idea of
adding progress messages throughout configure, then I'll make some time
to work on that.

Don't want to spend all the effort if such a patch is going to get reject=
ed
though...

Any further opinions for/against ?

Regards,
Daniel
--=20
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange=
/ :|
|: http://libvirt.org              -o-             http://virt-manager.or=
g :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr=
/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vn=
c :|