[Qemu-devel] [PATCH 0/3] [trivial] Fix linking when using UST tracing

[Qemu-devel] [PATCH 0/3] [trivial] Fix linking when using UST tracing

[Lluís Vilanova]

Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
---

Lluís Vilanova (3):
      configure: Fix typo 'lib_qga' -> 'libs_qga'
      configure: Link QEMU against 'liburcu-bp'
      configure: Link qga against UST tracing related libraries


 configure |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

[Qemu-devel] [PATCH 1/3] configure: Fix typo 'lib_qga' -> 'libs_qga'

[Lluís Vilanova]

Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
---
 configure |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/configure b/configure
index bea4a2c..c7be13d 100755
--- a/configure
+++ b/configure
@@ -526,7 +526,7 @@ EOF
   bindir="\${prefix}"
   sysconfdir="\${prefix}"
   confsuffix=""
-  libs_qga="-lws2_32 -lwinmm -lpowrprof $lib_qga"
+  libs_qga="-lws2_32 -lwinmm -lpowrprof $libs_qga"
 fi
 
 werror=""

Re: [Qemu-devel] [PATCH 1/3] configure: Fix typo 'lib_qga' -> 'libs_qga'

[Stefan Hajnoczi]

On Mon, Apr 02, 2012 at 02:49:38PM +0200, Lluís Vilanova wrote:
> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
> ---
>  configure |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/configure b/configure
> index bea4a2c..c7be13d 100755
> --- a/configure
> +++ b/configure
> @@ -526,7 +526,7 @@ EOF
>    bindir="\${prefix}"
>    sysconfdir="\${prefix}"
>    confsuffix=""
> -  libs_qga="-lws2_32 -lwinmm -lpowrprof $lib_qga"
> +  libs_qga="-lws2_32 -lwinmm -lpowrprof $libs_qga"
>  fi
>  
>  werror=""

An equivalent patch is already in the trivial-patches tree:
http://patchwork.ozlabs.org/patch/148919/

Thanks,
Stefan

[Qemu-devel] [PATCH 2/3] configure: Link QEMU against 'liburcu-bp'

[Lluís Vilanova]

This library is needed when using 'ust/tracepoint.h'.

Signed-off-by: Harsh Prateek Bora <harsh@linux.vnet.ibm.com>
Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
---
 configure |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/configure b/configure
index c7be13d..30591b0 100755
--- a/configure
+++ b/configure
@@ -2672,7 +2672,7 @@ if test "$trace_backend" = "ust"; then
 int main(void) { return 0; }
 EOF
   if compile_prog "" "" ; then
-    LIBS="-lust $LIBS"
+    LIBS="-lust -lurcu-bp $LIBS"
   else
     echo
     echo "Error: Trace backend 'ust' missing libust header files"

Re: [Qemu-devel] [PATCH 2/3] configure: Link QEMU against 'liburcu-bp'

[Stefan Hajnoczi]

On Mon, Apr 02, 2012 at 02:49:44PM +0200, Lluís Vilanova wrote:
> This library is needed when using 'ust/tracepoint.h'.
> 
> Signed-off-by: Harsh Prateek Bora <harsh@linux.vnet.ibm.com>
> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
> ---
>  configure |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

I also sent an email to lttng-devel asking if pkg-config --libs ust
should include this, you are CCed.  If the library details will change
it would be best for us to use pkg-config.

Stefan

[Qemu-devel] [PATCH 3/3] configure: Link qga against UST tracing related libraries

[Lluís Vilanova]

Signed-off-by: Harsh Prateek Bora <harsh@linux.vnet.ibm.com>
Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
---
 configure |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/configure b/configure
index 30591b0..e72f66f 100755
--- a/configure
+++ b/configure
@@ -2673,6 +2673,7 @@ int main(void) { return 0; }
 EOF
   if compile_prog "" "" ; then
     LIBS="-lust -lurcu-bp $LIBS"
+    libs_qga="-lust -lurcu-bp $libs_qga"
   else
     echo
     echo "Error: Trace backend 'ust' missing libust header files"

Re: [Qemu-devel] [PATCH 3/3] configure: Link qga against UST tracing related libraries

[Stefan Hajnoczi]

On Mon, Apr 02, 2012 at 02:49:49PM +0200, Lluís Vilanova wrote:
> Signed-off-by: Harsh Prateek Bora <harsh@linux.vnet.ibm.com>
> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
> ---
>  configure |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

It would be nice to clean up libs_qga in the future so that common
library lists can be reused instead of duplicating them in both LIBS and
libs_qga.  Anyway, thanks for this fix.

Stefan