From: "Michael S. Tsirkin" <mst@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
gleb@redhat.com, qemu-devel@nongnu.org,
Isaku Yamahata <yamahata@valinux.co.jp>,
Gerd Hoffmann <kraxel@redhat.com>,
imammedo@redhat.com, Paolo Bonzini <pbonzini@redhat.com>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCHv3] piix: fix up/down races
Date: Tue, 3 Apr 2012 16:51:06 +0300 [thread overview]
Message-ID: <20120403135105.GA11768@redhat.com> (raw)
In-Reply-To: <20120403125618.GA20059@redhat.com>
On Tue, Apr 03, 2012 at 03:56:18PM +0300, Michael S. Tsirkin wrote:
> > > + /*
> > > + * Clear DOWN register - this is good for a case where guest can't
> > > + * write to CLR_DOWN because of VM reset, and for compatibility with
> > > + * old guests which do not have CLR_DOWN.
> > > + */
> > > + s->pci0_status.down &= ~(1U << slot);
> >
> > Should we clear "up" here too?
>
> On eject clearing "up" is probably OK. However I'm not sure
> what purpose would it serve, and it seems the less hacks we do the
> better.
I added a comment to clarify this.
prev parent reply other threads:[~2012-04-03 13:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 10:03 [Qemu-devel] [PATCHv3] piix: fix up/down races Michael S. Tsirkin
2012-04-02 18:59 ` Alex Williamson
2012-04-02 19:20 ` Michael S. Tsirkin
2012-04-03 6:14 ` Igor Mammedov
2012-04-03 6:40 ` Igor Mammedov
2012-04-03 10:05 ` Michael S. Tsirkin
2012-04-03 13:59 ` Alex Williamson
2012-04-03 14:48 ` Michael S. Tsirkin
2012-04-03 12:56 ` Michael S. Tsirkin
2012-04-03 13:51 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120403135105.GA11768@redhat.com \
--to=mst@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=aurelien@aurel32.net \
--cc=gleb@redhat.com \
--cc=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).