From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SF7av-0007a5-W0 for qemu-devel@nongnu.org; Tue, 03 Apr 2012 13:32:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SF7ap-0002h9-NC for qemu-devel@nongnu.org; Tue, 03 Apr 2012 13:32:37 -0400 Received: from mo-p00-ob.rzone.de ([81.169.146.160]:61973) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SF7ap-0002gx-DD for qemu-devel@nongnu.org; Tue, 03 Apr 2012 13:32:31 -0400 Date: Tue, 3 Apr 2012 19:32:25 +0200 From: Olaf Hering Message-ID: <20120403173224.GA22140@aepfle.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Subject: [Qemu-devel] [PATCH v2] qemu/configure: fix CFLAGS handling for i386 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, xen-devel@lists.xensource.com configure will generate incorrect CFLAGS which will lead to compile errors due to unknown gcc options, iff CFLAGS was already in the environment during configure invocation. Add a space before the -march=i486 gcc option. Remove += operator usage because configure is not a bash script. This patch is against the qemu-xen tree, but it should apply also to qemu.git since it has the same issue. Please apply to both trees. Signed-off-by: Olaf Hering --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: qemu-xen-dir-remote/configure =================================================================== --- qemu-xen-dir-remote.orig/configure +++ qemu-xen-dir-remote/configure @@ -2637,7 +2637,7 @@ int main(int argc, char **argv) } EOF if ! compile_prog "" "" ; then - CFLAGS+="-march=i486" + CFLAGS="$CFLAGS -march=i486" fi fi