From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42891) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFDu0-0001vh-Vr for qemu-devel@nongnu.org; Tue, 03 Apr 2012 20:16:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SFDtt-0002MK-5J for qemu-devel@nongnu.org; Tue, 03 Apr 2012 20:16:43 -0400 Received: from e23smtp09.au.ibm.com ([202.81.31.142]:44600) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFDts-0002Le-By for qemu-devel@nongnu.org; Tue, 03 Apr 2012 20:16:37 -0400 Received: from /spool/local by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 4 Apr 2012 01:06:05 +1000 Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q3409t1f3616836 for ; Wed, 4 Apr 2012 10:10:00 +1000 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q340GDtd031382 for ; Wed, 4 Apr 2012 10:16:13 +1000 Date: Wed, 4 Apr 2012 10:12:58 +1000 From: David Gibson Message-ID: <20120404001258.GB17423@truffala.fritz.box> References: <1332816201-5072-1-git-send-email-david@gibson.dropbear.id.au> <4F757DBD.9090206@suse.de> <4F757E21.1030808@suse.de> <20120331085013.GF19352@truffala.fritz.box> <4F7959F8.9020008@suse.de> <20120403005143.GC7481@truffala.fritz.box> <4F7ABA76.8030107@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4F7ABA76.8030107@suse.de> Subject: Re: [Qemu-devel] [PATCH] Better support for dma_addr_t variables List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, mst@redhat.com On Tue, Apr 03, 2012 at 10:53:10AM +0200, Andreas Färber wrote: > Am 03.04.2012 02:51, schrieb David Gibson: > > On Mon, Apr 02, 2012 at 09:49:12AM +0200, Andreas Färber wrote: > >> Am 31.03.2012 10:50, schrieb David Gibson: > >>> On Fri, Mar 30, 2012 at 11:34:25AM +0200, Andreas Färber wrote: > >>>> Am 30.03.2012 11:32, schrieb Andreas Färber: > >>>>> Am 27.03.2012 04:43, schrieb David Gibson: > >>>>>> diff --git a/hw/qdev-dma.h b/hw/qdev-dma.h > >>>>>> new file mode 100644 > >>>>>> index 0000000..e407771 > >>>>>> --- /dev/null > >>>>>> +++ b/hw/qdev-dma.h > >>>>>> @@ -0,0 +1,4 @@ > >>>>>> +#include "qdev-addr.h" > >>>>>> + > >>>>>> +#define DEFINE_PROP_DMAADDR(_n, _s, _f, _d) \ > >>>>>> + DEFINE_PROP_TADDR(_n, _s, _f, _d) > >>>>> > >>>>> Is a new header just for this really needed? It's not being used in this > >>>>> patch, so its necessity is hard to judge. ;) > >>>> > >>>> Additionally it's missing a license notice. > >>> > >>> Just like qdev-addr.h. And qdev.h for that matter. > >>> > >>> You seriously want a license notice for two lines of trivial macro? > >> > >> Yes, the issue here is under what license the file is. It's a new file, > >> so in lack of a license statement is it under GPLv2 because QEMU as a > >> whole currently is? Thus a header explicitly saying that it's under > >> GPLv2+ (or BSD or MIT/X11 or ...) would be appreciated to avoid further > >> complications. Compare our GPLv2+ relicensing page: > >> > >> http://wiki.qemu.org/Relicensing > > > > It's 4 trivial lines. Well under the copyrightability threshold even > > by the paranoid estimates of IBM Legal. > > Tell that to your IBM colleague. We had an argument about 1 line of > trivial code replacement (not even new code) that kept us from > relicensing target-unicore32/helper.c just recently. > This is not me who's being paranoid about lines of code, really. I've > even heard that header files may not even be the subject of licenses at > all in some legislations. I'm just picky and sometimes spot the odd sock > from afar. ;) Sigh. Okay. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson