From: David Gibson <dwg@au1.ibm.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: aliguori@us.ibm.com, mtosatti@redhat.com, qemu-devel@nongnu.org,
Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH, RESEND] kvm: Fix dirty tracking with large kernel page size
Date: Thu, 5 Apr 2012 00:24:58 +1000 [thread overview]
Message-ID: <20120404142458.GB19379@truffala.fritz.box> (raw)
In-Reply-To: <4F7C295D.8090202@siemens.com>
On Wed, Apr 04, 2012 at 12:58:37PM +0200, Jan Kiszka wrote:
> On 2012-04-04 03:12, David Gibson wrote:
> >> Also, what's about coalesced MMIO? I see that the ring definition
> >> depends on [TARGET_]PAGE_SIZE. What page size does the power kernel use
> >> for it, and does it make a relevant difference for space?
> >
> > Hr, so the HV variant of Power KVM doesn't do coalesced mmio. The PR
> > variant does, but I don't know enough about it to easily answer that.
> > If there's a bug there, it hasn't bitten yet, so how about we fix that
> > another day.
>
> Not really a smart approach, specifically now that we are aware of a
> potential problem here.
My point is that the fact that there may be another bug out there
should sure as hell not hold up putting this bug fix in. The bugs may
have similar causes and solutions, but they're entirely different code
paths and the other fix will in no way replace or subsume this one.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2012-04-05 1:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 4:04 [Qemu-devel] [PATCH, RESEND] kvm: Fix dirty tracking with large kernel page size David Gibson
2012-04-02 4:14 ` Benjamin Herrenschmidt
2012-04-03 7:08 ` Jan Kiszka
2012-04-04 1:12 ` David Gibson
2012-04-04 10:58 ` Jan Kiszka
2012-04-04 14:24 ` David Gibson [this message]
2012-04-05 7:32 ` Jan Kiszka
-- strict thread matches above, loose matches on Subject: below --
2012-04-04 1:15 David Gibson
2012-04-04 8:41 ` Avi Kivity
2012-05-09 22:23 ` Anthony Liguori
2012-05-10 9:27 ` Avi Kivity
2012-05-10 10:49 ` Jan Kiszka
2012-05-10 10:55 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120404142458.GB19379@truffala.fritz.box \
--to=dwg@au1.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).