From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58620)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1SFW3D-0004YL-CV
	for qemu-devel@nongnu.org; Wed, 04 Apr 2012 15:39:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1SFW32-0001Bm-Hx
	for qemu-devel@nongnu.org; Wed, 04 Apr 2012 15:39:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:7112)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1SFW32-0001B2-AG
	for qemu-devel@nongnu.org; Wed, 04 Apr 2012 15:39:16 -0400
Date: Wed, 4 Apr 2012 22:39:18 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20120404193918.GD8967@redhat.com>
References: <1332062822-14342-1-git-send-email-dmitry.fleytman@ravellosystems.com>
	<1332062822-14342-8-git-send-email-dmitry.fleytman@ravellosystems.com>
	<4F7C3401.1040104@ravellosystems.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4F7C3401.1040104@ravellosystems.com>
Subject: Re: [Qemu-devel] [PATCH 7/7 v5] VMXNET3 paravirtualized device
 implementation Interface type "vmxnet3" added.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Izik Eidus <izik.eidus@ravellosystems.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Alex Fishman <alex.fishman@ravellosystems.com>, Tamir Shomer <tamirs@daynix.com>, yvugenfi@redhat.com, qemu-devel@nongnu.org, Yan Vugenfirer <yan@daynix.com>, Dmitry Fleytman <dmitry@daynix.com>

On Wed, Apr 04, 2012 at 02:44:01PM +0300, Izik Eidus wrote:
> Hi,
> 
> What about this patch?, everything that was asked from Dmitry was
> accomplished...
> What prevent us from progressing with merging this patch?
> 
> Thanks.

Off the top of my head: issues with v5:
polluting global namespace, must scope names
appropriately with vmxnet_ VMXNET_ unless they have file scope.
Don't use names with _ followed by an upper case letter
or that star with two underscores. Don't mix underscores and mixed case.
Don't stick any new types in net.c/pci.c - new devices should use -device
not -net. Global stuff like ethernet header size
should move to central place instead of copy paste.


> On 18/03/2012 11:27, Dmitry Fleytman wrote:
> >Signed-off-by: Dmitry Fleytman<dmitry@daynix.com>
> >Signed-off-by: Yan Vugenfirer<yan@daynix.com>
> >---
> >  Makefile.objs           |    1 +
> >  default-configs/pci.mak |    1 +
> >  hw/pci.c                |    2 +
> >  hw/pci.h                |    1 +
> >  hw/vmxnet3.c            | 2454 +++++++++++++++++++++++++++++++++++++++++++++++
> >  hw/vmxnet3.h            |  757 +++++++++++++++
> >  net.c                   |    2 +-
> >  7 files changed, 3217 insertions(+), 1 deletions(-)
> >  create mode 100644 hw/vmxnet3.c
> >  create mode 100644 hw/vmxnet3.h
> >