From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45436) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFg2H-000570-99 for qemu-devel@nongnu.org; Thu, 05 Apr 2012 02:19:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SFg2C-0007ig-Fm for qemu-devel@nongnu.org; Thu, 05 Apr 2012 02:19:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4391) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SFg2C-0007gj-7j for qemu-devel@nongnu.org; Thu, 05 Apr 2012 02:19:04 -0400 From: Alex Williamson Date: Wed, 04 Apr 2012 23:51:25 -0600 Message-ID: <20120405055125.31461.42022.stgit@bling.home> In-Reply-To: <20120405050848.31461.10826.stgit@bling.home> References: <20120405050848.31461.10826.stgit@bling.home> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH 4/5] acpi_piix4: Remove PCI_RMV_BASE write code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, mst@redhat.com Cc: aliguori@us.ibm.com, gleb@redhat.com, jbaron@redhat.com, yamahata@valinux.co.jp, alex.williamson@redhat.com, kraxel@redhat.com, pbonzini@redhat.com, imammedo@redhat.com, aurelien@aurel32.net Achieves the same result with less code. Signed-off-by: Alex Williamson --- docs/specs/acpi_pci_hotplug.txt | 2 +- hw/acpi_piix4.c | 6 ------ 2 files changed, 1 insertions(+), 7 deletions(-) diff --git a/docs/specs/acpi_pci_hotplug.txt b/docs/specs/acpi_pci_hotplug.txt index 1e61d19..44a28da 100644 --- a/docs/specs/acpi_pci_hotplug.txt +++ b/docs/specs/acpi_pci_hotplug.txt @@ -34,4 +34,4 @@ PCI removability status (IO port 0xae0c-0xae0f, 4-byte access): ----------------------------------------------- Used by ACPI BIOS _RMV method to indicate removability status to OS. One -bit per slot. +bit per slot. Read-only diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index c1b1532..a6fe260 100644 --- a/hw/acpi_piix4.c +++ b/hw/acpi_piix4.c @@ -514,11 +514,6 @@ static uint32_t pcirmv_read(void *opaque, uint32_t addr) return s->pci0_hotplug_enable; } -static void pcirmv_write(void *opaque, uint32_t addr, uint32_t val) -{ - return; -} - extern const char *global_cpu_model; static int piix4_device_hotplug(DeviceState *qdev, PCIDevice *dev, @@ -545,7 +540,6 @@ static void piix4_acpi_system_hot_add_init(PCIBus *bus, PIIX4PMState *s) register_ioport_write(PCI_EJ_BASE, 4, 4, pciej_write, s); - register_ioport_write(PCI_RMV_BASE, 4, 4, pcirmv_write, s); register_ioport_read(PCI_RMV_BASE, 4, 4, pcirmv_read, s); pci_bus_hotplug(bus, piix4_device_hotplug, &s->dev.qdev);