[Qemu-devel] [PULL] pci, virtio, net

[Qemu-devel] [PULL] pci, virtio, net

[Michael S. Tsirkin]

I'm trying a signed pull request now. You can check the signature
on for_anthony if you like, and if your git is recent enough
it will do it for you automatically.

The following changes since commit ae7d54d489540b49b7c13a7df7ddc220588a2ced:

  target-lm32/microblaze: Drop second CPU{LM32, MB}State typedef (2012-03-14 19:48:37 -0500)

are available in the git repository at:

  git://github.com/mstsirkin/qemu.git for_anthony

for you to fetch changes up to ff71f2e8cacefae99179993204172bc65e4303df:

  rtl8139: do the network/host communication only in normal operating mode (2012-03-16 01:04:51 +0200)

----------------------------------------------------------------
pci, virtio, net

This includes a new standard pci bridge device,
as well as a collection of misc fixes for
pci, virito and rtl8139.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

----------------------------------------------------------------
Anthony PERARD (3):
      pci: Do not check if a bus exist in pci_parse_devaddr.
      pci_regs: Fix value of PCI_EXP_TYPE_RC_EC.
      pci_regs: Add PCI_EXP_TYPE_PCIE_BRIDGE

Jason Wang (6):
      rtl8139: limit transmission buffer size in c+ mode
      rtl8139: remove unused marco
      rtl8139: support byte read to TxStatus registers
      net: move compute_mcast_idx() to net.h
      rtl8139: correctly check the opmode
      rtl8139: do the network/host communication only in normal operating mode

Michael S. Tsirkin (12):
      pci_bridge: fix status: do not override cap bit
      pci: don't export an internal function
      pci: make another unused extern function static
      pci_bridge: user-friendly default bus name
      shpc: standard hot plug controller
      slotid: add slot id capability
      pci: add standard bridge device
      pci: set memory type for memory behind the bridge
      pcie: drop functionality moved to core
      pci: fix bridge IO/BASE
      pci_bridge: upper 32 bit are long registers
      virtio-net: add DATA_VALID flag

 Makefile.objs       |    4 +-
 hw/eepro100.c       |   25 --
 hw/ne2000.c         |   24 --
 hw/opencores_eth.c  |   25 --
 hw/pci.c            |   28 +-
 hw/pci.h            |   11 +-
 hw/pci_bridge.c     |   22 ++-
 hw/pci_bridge_dev.c |  174 +++++++++++++
 hw/pci_regs.h       |    3 +-
 hw/pcie_port.c      |   12 +-
 hw/rtl8139.c        |   88 ++++---
 hw/shpc.c           |  681 +++++++++++++++++++++++++++++++++++++++++++++++++++
 hw/shpc.h           |   48 ++++
 hw/slotid_cap.c     |   44 ++++
 hw/slotid_cap.h     |   11 +
 hw/virtio-net.h     |    1 +
 net.c               |   23 ++
 net.h               |    3 +
 qemu-common.h       |    1 +
 19 files changed, 1078 insertions(+), 150 deletions(-)
 create mode 100644 hw/pci_bridge_dev.c
 create mode 100644 hw/shpc.c
 create mode 100644 hw/shpc.h
 create mode 100644 hw/slotid_cap.c
 create mode 100644 hw/slotid_cap.h

Re: [Qemu-devel] [PULL] pci, virtio, net

[Anthony Liguori]

On 03/15/2012 06:49 PM, Michael S. Tsirkin wrote:
> I'm trying a signed pull request now. You can check the signature
> on for_anthony if you like, and if your git is recent enough
> it will do it for you automatically.
>
> The following changes since commit ae7d54d489540b49b7c13a7df7ddc220588a2ced:
>
>    target-lm32/microblaze: Drop second CPU{LM32, MB}State typedef (2012-03-14 19:48:37 -0500)
>
> are available in the git repository at:
>
>    git://github.com/mstsirkin/qemu.git for_anthony

I don't see a for_anthony branch in that tree.  I do see a pci branch, did you 
mess up the pull request?

Regards,

Anthony Liguori

>
> for you to fetch changes up to ff71f2e8cacefae99179993204172bc65e4303df:
>
>    rtl8139: do the network/host communication only in normal operating mode (2012-03-16 01:04:51 +0200)
>
> ----------------------------------------------------------------
> pci, virtio, net
>
> This includes a new standard pci bridge device,
> as well as a collection of misc fixes for
> pci, virito and rtl8139.
>
> Signed-off-by: Michael S. Tsirkin<mst@redhat.com>
>
> ----------------------------------------------------------------
> Anthony PERARD (3):
>        pci: Do not check if a bus exist in pci_parse_devaddr.
>        pci_regs: Fix value of PCI_EXP_TYPE_RC_EC.
>        pci_regs: Add PCI_EXP_TYPE_PCIE_BRIDGE
>
> Jason Wang (6):
>        rtl8139: limit transmission buffer size in c+ mode
>        rtl8139: remove unused marco
>        rtl8139: support byte read to TxStatus registers
>        net: move compute_mcast_idx() to net.h
>        rtl8139: correctly check the opmode
>        rtl8139: do the network/host communication only in normal operating mode
>
> Michael S. Tsirkin (12):
>        pci_bridge: fix status: do not override cap bit
>        pci: don't export an internal function
>        pci: make another unused extern function static
>        pci_bridge: user-friendly default bus name
>        shpc: standard hot plug controller
>        slotid: add slot id capability
>        pci: add standard bridge device
>        pci: set memory type for memory behind the bridge
>        pcie: drop functionality moved to core
>        pci: fix bridge IO/BASE
>        pci_bridge: upper 32 bit are long registers
>        virtio-net: add DATA_VALID flag
>
>   Makefile.objs       |    4 +-
>   hw/eepro100.c       |   25 --
>   hw/ne2000.c         |   24 --
>   hw/opencores_eth.c  |   25 --
>   hw/pci.c            |   28 +-
>   hw/pci.h            |   11 +-
>   hw/pci_bridge.c     |   22 ++-
>   hw/pci_bridge_dev.c |  174 +++++++++++++
>   hw/pci_regs.h       |    3 +-
>   hw/pcie_port.c      |   12 +-
>   hw/rtl8139.c        |   88 ++++---
>   hw/shpc.c           |  681 +++++++++++++++++++++++++++++++++++++++++++++++++++
>   hw/shpc.h           |   48 ++++
>   hw/slotid_cap.c     |   44 ++++
>   hw/slotid_cap.h     |   11 +
>   hw/virtio-net.h     |    1 +
>   net.c               |   23 ++
>   net.h               |    3 +
>   qemu-common.h       |    1 +
>   19 files changed, 1078 insertions(+), 150 deletions(-)
>   create mode 100644 hw/pci_bridge_dev.c
>   create mode 100644 hw/shpc.c
>   create mode 100644 hw/shpc.h
>   create mode 100644 hw/slotid_cap.c
>   create mode 100644 hw/slotid_cap.h
>
>

Re: [Qemu-devel] [PULL] pci, virtio, net

[Anthony Liguori]

On 03/15/2012 06:49 PM, Michael S. Tsirkin wrote:
> I'm trying a signed pull request now. You can check the signature
> on for_anthony if you like, and if your git is recent enough
> it will do it for you automatically.
>
> The following changes since commit ae7d54d489540b49b7c13a7df7ddc220588a2ced:
>
>    target-lm32/microblaze: Drop second CPU{LM32, MB}State typedef (2012-03-14 19:48:37 -0500)
>
> are available in the git repository at:
>
>    git://github.com/mstsirkin/qemu.git for_anthony

Pulled.  Thanks.

Regards,

Anthony Liguori

>
> for you to fetch changes up to ff71f2e8cacefae99179993204172bc65e4303df:
>
>    rtl8139: do the network/host communication only in normal operating mode (2012-03-16 01:04:51 +0200)
>
> ----------------------------------------------------------------
> pci, virtio, net
>
> This includes a new standard pci bridge device,
> as well as a collection of misc fixes for
> pci, virito and rtl8139.
>
> Signed-off-by: Michael S. Tsirkin<mst@redhat.com>
>
> ----------------------------------------------------------------
> Anthony PERARD (3):
>        pci: Do not check if a bus exist in pci_parse_devaddr.
>        pci_regs: Fix value of PCI_EXP_TYPE_RC_EC.
>        pci_regs: Add PCI_EXP_TYPE_PCIE_BRIDGE
>
> Jason Wang (6):
>        rtl8139: limit transmission buffer size in c+ mode
>        rtl8139: remove unused marco
>        rtl8139: support byte read to TxStatus registers
>        net: move compute_mcast_idx() to net.h
>        rtl8139: correctly check the opmode
>        rtl8139: do the network/host communication only in normal operating mode
>
> Michael S. Tsirkin (12):
>        pci_bridge: fix status: do not override cap bit
>        pci: don't export an internal function
>        pci: make another unused extern function static
>        pci_bridge: user-friendly default bus name
>        shpc: standard hot plug controller
>        slotid: add slot id capability
>        pci: add standard bridge device
>        pci: set memory type for memory behind the bridge
>        pcie: drop functionality moved to core
>        pci: fix bridge IO/BASE
>        pci_bridge: upper 32 bit are long registers
>        virtio-net: add DATA_VALID flag
>
>   Makefile.objs       |    4 +-
>   hw/eepro100.c       |   25 --
>   hw/ne2000.c         |   24 --
>   hw/opencores_eth.c  |   25 --
>   hw/pci.c            |   28 +-
>   hw/pci.h            |   11 +-
>   hw/pci_bridge.c     |   22 ++-
>   hw/pci_bridge_dev.c |  174 +++++++++++++
>   hw/pci_regs.h       |    3 +-
>   hw/pcie_port.c      |   12 +-
>   hw/rtl8139.c        |   88 ++++---
>   hw/shpc.c           |  681 +++++++++++++++++++++++++++++++++++++++++++++++++++
>   hw/shpc.h           |   48 ++++
>   hw/slotid_cap.c     |   44 ++++
>   hw/slotid_cap.h     |   11 +
>   hw/virtio-net.h     |    1 +
>   net.c               |   23 ++
>   net.h               |    3 +
>   qemu-common.h       |    1 +
>   19 files changed, 1078 insertions(+), 150 deletions(-)
>   create mode 100644 hw/pci_bridge_dev.c
>   create mode 100644 hw/shpc.c
>   create mode 100644 hw/shpc.h
>   create mode 100644 hw/slotid_cap.c
>   create mode 100644 hw/slotid_cap.h
>
>

Re: [Qemu-devel] [PULL] pci, virtio, net

[Michael S. Tsirkin]

On Mon, Mar 19, 2012 at 01:11:16PM -0500, Anthony Liguori wrote:
> On 03/15/2012 06:49 PM, Michael S. Tsirkin wrote:
> >I'm trying a signed pull request now. You can check the signature
> >on for_anthony if you like, and if your git is recent enough
> >it will do it for you automatically.
> >
> >The following changes since commit ae7d54d489540b49b7c13a7df7ddc220588a2ced:
> >
> >   target-lm32/microblaze: Drop second CPU{LM32, MB}State typedef (2012-03-14 19:48:37 -0500)
> >
> >are available in the git repository at:
> >
> >   git://github.com/mstsirkin/qemu.git for_anthony
> 
> Pulled.  Thanks.
> 
> Regards,
> 
> Anthony Liguori

I have another one all ready to go but this wasn't pushed yet.
Want me to send it? Delay it?

-- 
MST

Re: [Qemu-devel] [PULL] pci, virtio, net

[Michael S. Tsirkin]

On Mon, Mar 19, 2012 at 01:11:16PM -0500, Anthony Liguori wrote:
> On 03/15/2012 06:49 PM, Michael S. Tsirkin wrote:
> >I'm trying a signed pull request now. You can check the signature
> >on for_anthony if you like, and if your git is recent enough
> >it will do it for you automatically.
> >
> >The following changes since commit ae7d54d489540b49b7c13a7df7ddc220588a2ced:
> >
> >   target-lm32/microblaze: Drop second CPU{LM32, MB}State typedef (2012-03-14 19:48:37 -0500)
> >
> >are available in the git repository at:
> >
> >   git://github.com/mstsirkin/qemu.git for_anthony
> 
> Pulled.  Thanks.
> 
> Regards,
> 
> Anthony Liguori
> >
> >for you to fetch changes up to ff71f2e8cacefae99179993204172bc65e4303df:
> >
> >   rtl8139: do the network/host communication only in normal operating mode (2012-03-16 01:04:51 +0200)

A lot of time passed and the master still does not appear
to be updated with these patches:

$ git fetch -v origin
>From git://git.qemu.org/qemu
 = [up to date]      master     -> origin/master
 = [up to date]      stable-0.10 -> origin/stable-0.10
 = [up to date]      stable-0.11 -> origin/stable-0.11
 = [up to date]      stable-0.12 -> origin/stable-0.12
 = [up to date]      stable-0.13 -> origin/stable-0.13
 = [up to date]      stable-0.14 -> origin/stable-0.14
 = [up to date]      stable-0.15 -> origin/stable-0.15
 = [up to date]      stable-1.0 -> origin/stable-1.0
 = [up to date]      staging    -> origin/staging
$ git log  --oneline
origin/master..ff71f2e8cacefae99179993204172bc65e4303df|wc -l
21

Is something wrong?
Also, staging is out-of-date, isn't it?
It would be nice to push it once in a while too.

> >
> >----------------------------------------------------------------
> >pci, virtio, net
> >
> >This includes a new standard pci bridge device,
> >as well as a collection of misc fixes for
> >pci, virito and rtl8139.
> >
> >Signed-off-by: Michael S. Tsirkin<mst@redhat.com>
> >
> >----------------------------------------------------------------
> >Anthony PERARD (3):
> >       pci: Do not check if a bus exist in pci_parse_devaddr.
> >       pci_regs: Fix value of PCI_EXP_TYPE_RC_EC.
> >       pci_regs: Add PCI_EXP_TYPE_PCIE_BRIDGE
> >
> >Jason Wang (6):
> >       rtl8139: limit transmission buffer size in c+ mode
> >       rtl8139: remove unused marco
> >       rtl8139: support byte read to TxStatus registers
> >       net: move compute_mcast_idx() to net.h
> >       rtl8139: correctly check the opmode
> >       rtl8139: do the network/host communication only in normal operating mode
> >
> >Michael S. Tsirkin (12):
> >       pci_bridge: fix status: do not override cap bit
> >       pci: don't export an internal function
> >       pci: make another unused extern function static
> >       pci_bridge: user-friendly default bus name
> >       shpc: standard hot plug controller
> >       slotid: add slot id capability
> >       pci: add standard bridge device
> >       pci: set memory type for memory behind the bridge
> >       pcie: drop functionality moved to core
> >       pci: fix bridge IO/BASE
> >       pci_bridge: upper 32 bit are long registers
> >       virtio-net: add DATA_VALID flag
> >
> >  Makefile.objs       |    4 +-
> >  hw/eepro100.c       |   25 --
> >  hw/ne2000.c         |   24 --
> >  hw/opencores_eth.c  |   25 --
> >  hw/pci.c            |   28 +-
> >  hw/pci.h            |   11 +-
> >  hw/pci_bridge.c     |   22 ++-
> >  hw/pci_bridge_dev.c |  174 +++++++++++++
> >  hw/pci_regs.h       |    3 +-
> >  hw/pcie_port.c      |   12 +-
> >  hw/rtl8139.c        |   88 ++++---
> >  hw/shpc.c           |  681 +++++++++++++++++++++++++++++++++++++++++++++++++++
> >  hw/shpc.h           |   48 ++++
> >  hw/slotid_cap.c     |   44 ++++
> >  hw/slotid_cap.h     |   11 +
> >  hw/virtio-net.h     |    1 +
> >  net.c               |   23 ++
> >  net.h               |    3 +
> >  qemu-common.h       |    1 +
> >  19 files changed, 1078 insertions(+), 150 deletions(-)
> >  create mode 100644 hw/pci_bridge_dev.c
> >  create mode 100644 hw/shpc.c
> >  create mode 100644 hw/shpc.h
> >  create mode 100644 hw/slotid_cap.c
> >  create mode 100644 hw/slotid_cap.h
> >
> >

[Qemu-devel] [PULL] pci, virtio, net

[Michael S. Tsirkin]

The following changes since commit d1afc48b7cfdb4490f322d5d82a2aae6d545ec06:

  SPARC64: implement addtional MMU faults related to nonfaulting load (2011-07-21 20:02:22 +0000)

are available in the git repository at:
  git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.git for_anthony

Amit Shah (3):
      virtio-blk: Fix memleak on exit
      virtio-net: don't use vdev after virtio_cleanup
      virtio: Plug memleak by freeing vdev

Isaku Yamahata (1):
      pcie_host: verify mmcfg address range

Jan Kiszka (1):
      pci: Common overflow prevention

Markus Armbruster (2):
      Fix automatically assigned network names for netdev
      Fix netdev name lookup in -device, device_add, netdev_del

Michael S. Tsirkin (1):
      virtio-pci: use generic logic for command access

 hw/pci.c        |    6 ++----
 hw/pci_host.c   |   24 ++++++++++++++++++++----
 hw/pci_host.h   |    6 ++++++
 hw/pcie_host.c  |   32 ++++++++++++++++++++++++--------
 hw/virtio-blk.c |    1 +
 hw/virtio-net.c |    2 +-
 hw/virtio-pci.c |   18 +++++++++---------
 hw/virtio.c     |    1 +
 net.c           |   19 +++++++++++++++----
 9 files changed, 79 insertions(+), 30 deletions(-)

Re: [Qemu-devel] [PULL] pci, virtio, net

[Markus Armbruster]

"Michael S. Tsirkin" <mst@redhat.com> writes:

> The following changes since commit d1afc48b7cfdb4490f322d5d82a2aae6d545ec06:
>
>   SPARC64: implement addtional MMU faults related to nonfaulting load (2011-07-21 20:02:22 +0000)
>
> are available in the git repository at:
>   git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.git for_anthony
>
> Amit Shah (3):
>       virtio-blk: Fix memleak on exit
>       virtio-net: don't use vdev after virtio_cleanup
>       virtio: Plug memleak by freeing vdev
>
> Isaku Yamahata (1):
>       pcie_host: verify mmcfg address range
>
> Jan Kiszka (1):
>       pci: Common overflow prevention
>
> Markus Armbruster (2):
>       Fix automatically assigned network names for netdev
>       Fix netdev name lookup in -device, device_add, netdev_del
>
> Michael S. Tsirkin (1):
>       virtio-pci: use generic logic for command access

Some of these (including mine) are obvious candidates for STABLE.
Perhaps even all of them.  Michael?

Re: [Qemu-devel] [PULL] pci, virtio, net

[Michael S. Tsirkin]

On Wed, Aug 03, 2011 at 10:15:03AM +0200, Markus Armbruster wrote:
> "Michael S. Tsirkin" <mst@redhat.com> writes:
> 
> > The following changes since commit d1afc48b7cfdb4490f322d5d82a2aae6d545ec06:
> >
> >   SPARC64: implement addtional MMU faults related to nonfaulting load (2011-07-21 20:02:22 +0000)
> >
> > are available in the git repository at:
> >   git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.git for_anthony
> >
> > Amit Shah (3):
> >       virtio-blk: Fix memleak on exit
> >       virtio-net: don't use vdev after virtio_cleanup
> >       virtio: Plug memleak by freeing vdev
> >
> > Isaku Yamahata (1):
> >       pcie_host: verify mmcfg address range
> >
> > Jan Kiszka (1):
> >       pci: Common overflow prevention
> >
> > Markus Armbruster (2):
> >       Fix automatically assigned network names for netdev
> >       Fix netdev name lookup in -device, device_add, netdev_del
> >
> > Michael S. Tsirkin (1):
> >       virtio-pci: use generic logic for command access
> 
> Some of these (including mine) are obvious candidates for STABLE.
> Perhaps even all of them.  Michael?

Amit's and your patches probably are. The pci changes probably aren't.

-- 
MST

Re: [Qemu-devel] [PULL] pci, virtio, net

[Anthony Liguori]

On 08/03/2011 03:19 AM, Michael S. Tsirkin wrote:
> On Wed, Aug 03, 2011 at 10:15:03AM +0200, Markus Armbruster wrote:
>> "Michael S. Tsirkin"<mst@redhat.com>  writes:
>>
>>> The following changes since commit d1afc48b7cfdb4490f322d5d82a2aae6d545ec06:
>>>
>>>    SPARC64: implement addtional MMU faults related to nonfaulting load (2011-07-21 20:02:22 +0000)
>>>
>>> are available in the git repository at:
>>>    git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.git for_anthony
>>>
>>> Amit Shah (3):
>>>        virtio-blk: Fix memleak on exit
>>>        virtio-net: don't use vdev after virtio_cleanup
>>>        virtio: Plug memleak by freeing vdev
>>>
>>> Isaku Yamahata (1):
>>>        pcie_host: verify mmcfg address range
>>>
>>> Jan Kiszka (1):
>>>        pci: Common overflow prevention
>>>
>>> Markus Armbruster (2):
>>>        Fix automatically assigned network names for netdev
>>>        Fix netdev name lookup in -device, device_add, netdev_del
>>>
>>> Michael S. Tsirkin (1):
>>>        virtio-pci: use generic logic for command access
>>
>> Some of these (including mine) are obvious candidates for STABLE.
>> Perhaps even all of them.  Michael?
>
> Amit's and your patches probably are. The pci changes probably aren't.

Michael,

Please send a pull request against the stable tree and CC Justin.

Regards,

Anthony Liguroi

Re: [Qemu-devel] [PULL] pci, virtio, net

[Anthony Liguori]

On 08/01/2011 09:27 AM, Michael S. Tsirkin wrote:
> The following changes since commit d1afc48b7cfdb4490f322d5d82a2aae6d545ec06:
>
>    SPARC64: implement addtional MMU faults related to nonfaulting load (2011-07-21 20:02:22 +0000)
>
> are available in the git repository at:
>    git://git.kernel.org/pub/scm/linux/kernel/git/mst/qemu.git for_anthony


Pulled.  Thanks.

Regards,

Anthony Liguori

>
> Amit Shah (3):
>        virtio-blk: Fix memleak on exit
>        virtio-net: don't use vdev after virtio_cleanup
>        virtio: Plug memleak by freeing vdev
>
> Isaku Yamahata (1):
>        pcie_host: verify mmcfg address range
>
> Jan Kiszka (1):
>        pci: Common overflow prevention
>
> Markus Armbruster (2):
>        Fix automatically assigned network names for netdev
>        Fix netdev name lookup in -device, device_add, netdev_del
>
> Michael S. Tsirkin (1):
>        virtio-pci: use generic logic for command access
>
>   hw/pci.c        |    6 ++----
>   hw/pci_host.c   |   24 ++++++++++++++++++++----
>   hw/pci_host.h   |    6 ++++++
>   hw/pcie_host.c  |   32 ++++++++++++++++++++++++--------
>   hw/virtio-blk.c |    1 +
>   hw/virtio-net.c |    2 +-
>   hw/virtio-pci.c |   18 +++++++++---------
>   hw/virtio.c     |    1 +
>   net.c           |   19 +++++++++++++++----
>   9 files changed, 79 insertions(+), 30 deletions(-)
>
>