From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:57171)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1SPXtZ-0001Q7-5F
	for qemu-devel@nongnu.org; Wed, 02 May 2012 07:39:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1SPXtX-0002V6-AQ
	for qemu-devel@nongnu.org; Wed, 02 May 2012 07:38:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:61765)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1SPXtX-0002Sa-1i
	for qemu-devel@nongnu.org; Wed, 02 May 2012 07:38:55 -0400
Date: Wed, 2 May 2012 14:38:57 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20120502113856.GA32746@redhat.com>
References: <1335958273-769-1-git-send-email-pbonzini@redhat.com>
	<1335958273-769-13-git-send-email-pbonzini@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1335958273-769-13-git-send-email-pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 12/21] pc: add back PCI.rombar compat
	property
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, qemu-devel@nongnu.org, afaerber@suse.de, liwp@linux.vnet.ibm.com

On Wed, May 02, 2012 at 01:31:04PM +0200, Paolo Bonzini wrote:
> This was erroneously dropped in d6c730086cbf24382eb8cff25551798769edfd84.
> 
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Yes I think it's a mistake, however we had:
-        },{
-            .driver   = "PCI",
-            .property = "rombar",
-            .value    = stringify(0),
-        },{

and not TYPE_PCI_DEVICE.

So let's put it back the way it was?

> ---
>  hw/pc_piix.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/hw/pc_piix.c b/hw/pc_piix.c
> index ef6afb1..15a62ef 100644
> --- a/hw/pc_piix.c
> +++ b/hw/pc_piix.c
> @@ -523,6 +523,10 @@ static QEMUMachine pc_machine_v0_12 = {
>              .driver   = "virtio-blk-pci",\
>              .property = "vectors",\
>              .value    = stringify(0),\
> +        },{\
> +            .driver   = TYPE_PCI_DEVICE,\
> +            .property = "rombar",\
> +            .value    = stringify(0),\
>          }
>  
>  static QEMUMachine pc_machine_v0_11 = {
> -- 
> 1.7.9.3
>