From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55685)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1SPXzQ-0003ji-TM
	for qemu-devel@nongnu.org; Wed, 02 May 2012 07:45:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1SPXzP-0005H6-5E
	for qemu-devel@nongnu.org; Wed, 02 May 2012 07:45:00 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39918)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1SPXzO-0005Gg-Tn
	for qemu-devel@nongnu.org; Wed, 02 May 2012 07:44:59 -0400
Date: Wed, 2 May 2012 14:44:52 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20120502114451.GB32746@redhat.com>
References: <1335958273-769-1-git-send-email-pbonzini@redhat.com>
	<1335958273-769-13-git-send-email-pbonzini@redhat.com>
	<20120502113856.GA32746@redhat.com> <4FA11D6A.7020407@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4FA11D6A.7020407@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 12/21] pc: add back PCI.rombar compat
	property
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: liwp@linux.vnet.ibm.com, peter.maydell@linaro.org, aliguori@us.ibm.com, qemu-devel@nongnu.org, afaerber@suse.de

On Wed, May 02, 2012 at 01:41:30PM +0200, Paolo Bonzini wrote:
> Il 02/05/2012 13:38, Michael S. Tsirkin ha scritto:
> > On Wed, May 02, 2012 at 01:31:04PM +0200, Paolo Bonzini wrote:
> >> This was erroneously dropped in d6c730086cbf24382eb8cff25551798769edfd84.
> >>
> >> Cc: Michael S. Tsirkin <mst@redhat.com>
> >> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > 
> > Yes I think it's a mistake, however we had:
> > -        },{
> > -            .driver   = "PCI",
> > -            .property = "rombar",
> > -            .value    = stringify(0),
> > -        },{
> > 
> > and not TYPE_PCI_DEVICE.
> 
> PCI->TYPE_PCI_DEVICE is required by earlier patches in the series.
> 
> Paolo

Haven't received them yet.
Ideally bugfixes come first in the series.