From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39538)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1SQHq3-0004Ee-0y
	for qemu-devel@nongnu.org; Fri, 04 May 2012 08:42:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1SQHq1-0006iC-1t
	for qemu-devel@nongnu.org; Fri, 04 May 2012 08:42:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:62333)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1SQHq0-0006hv-QD
	for qemu-devel@nongnu.org; Fri, 04 May 2012 08:42:20 -0400
Date: Fri, 4 May 2012 13:42:14 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20120504124214.GB2177@redhat.com>
References: <20120502193256.6508.86360.stgit@sifl> <4548305.DtX99stsJu@sifl>
	<alpine.LNX.2.00.1205040325480.12903@qrag.fhfr.qr>
	<4659908.x6KEQUt2IX@sifl>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <4659908.x6KEQUt2IX@sifl>
Subject: Re: [Qemu-devel] [PATCH v2] vnc: disable VNC password
 authentication (security type 2) when in FIPS mode
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Moore <pmoore@redhat.com>
Cc: qemu-devel Developers <qemu-devel@nongnu.org>, Roman Drahtmueller <draht@suse.de>, Alexander Graf <agraf@suse.de>

On Fri, May 04, 2012 at 08:39:04AM -0400, Paul Moore wrote:
> On Friday, May 04, 2012 04:01:09 AM Roman Drahtmueller wrote:

> > Two problems:
> > 1) openssl may not come with FIPS support. proc file is ignored.
> > 2) openssl may run in FIPS mode for reasons other than fips=1 on the
> >    kernel cmdline (environment, ...).
> >
> > Suggested way to handle this:
> > 
> > 1) compile-time check if <openssl/fips.h> exists.
> >    Ignore fips specifics if not, otherwise:
> > 2) use int FIPS_mode(void) for what it's there:
> > 
> > #ifdef _QEMU_FIPS 		/* or whatever */
> > #include <openssl/fips.h>
> >   vs->fips = FIPS_mode();
> > #endif
> > 
> > and skip fips_enabled(void).
> > 
> > Much easier!

QEMU does not use OpenSSL for anything [1], it uses GNUTLS, so I would
not be in favour of using OpenSSL for this. 

Daniel

[1] Yes the libspice-server.so uses OpenSSL which is a shame, but that
    can be sorted out one day.
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|