From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51184)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kevin@koconnor.net>) id 1SQIMT-0005Fu-I5
	for qemu-devel@nongnu.org; Fri, 04 May 2012 09:15:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kevin@koconnor.net>) id 1SQIMR-0004UA-Oc
	for qemu-devel@nongnu.org; Fri, 04 May 2012 09:15:53 -0400
Received: from mail-qc0-f173.google.com ([209.85.216.173]:38395)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kevin@koconnor.net>) id 1SQIMR-0004Tt-Ko
	for qemu-devel@nongnu.org; Fri, 04 May 2012 09:15:51 -0400
Received: by qcsc20 with SMTP id c20so2003431qcs.4
	for <qemu-devel@nongnu.org>; Fri, 04 May 2012 06:15:47 -0700 (PDT)
Date: Fri, 4 May 2012 09:15:46 -0400
From: Kevin O'Connor <kevin@koconnor.net>
Message-ID: <20120504131546.GA668@morn.localdomain>
References: <1336119687-6295-1-git-send-email-kraxel@redhat.com>
	<1336119687-6295-2-git-send-email-kraxel@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1336119687-6295-2-git-send-email-kraxel@redhat.com>
Subject: Re: [Qemu-devel] [SeaBIOS] [seabios patch 1/5] pci: init all devices
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: seabios@seabios.org, qemu-devel@nongnu.org

On Fri, May 04, 2012 at 10:21:23AM +0200, Gerd Hoffmann wrote:
> seabios used to initialize root bus devices only, with this patch
> devices behind pci bridges are initialized too.  This allows to boot
> from virtio devices behind pci bridges.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  src/pciinit.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/src/pciinit.c b/src/pciinit.c
> index 25b04ac..6a7a0d2 100644
> --- a/src/pciinit.c
> +++ b/src/pciinit.c
> @@ -213,9 +213,6 @@ static void pci_bios_init_devices(void)
>  {
>      struct pci_device *pci;
>      foreachpci(pci) {
> -        if (pci_bdf_to_bus(pci->bdf) != 0)
> -            // Only init devices on host bus.
> -            break;

I think this will then assign an incorrect PCI_INTERRUPT_LINE value to
non root bus devices.

-Kevin