From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:50694)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SQLiS-0005b7-Ju
	for qemu-devel@nongnu.org; Fri, 04 May 2012 12:50:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SQLiQ-0006E5-4K
	for qemu-devel@nongnu.org; Fri, 04 May 2012 12:50:48 -0400
Received: from mx1.redhat.com ([209.132.183.28]:20268)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SQLiP-0006Dm-SH
	for qemu-devel@nongnu.org; Fri, 04 May 2012 12:50:46 -0400
Date: Fri, 4 May 2012 13:50:54 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120504135054.698444ec@doriath.home>
In-Reply-To: <4FA4062A.8060207@redhat.com>
References: <1336143722-15050-1-git-send-email-lcapitulino@redhat.com>
	<1336143722-15050-4-git-send-email-lcapitulino@redhat.com>
	<4FA4062A.8060207@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/4] runstate: introduce suspended state
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org, kraxel@redhat.com

On Fri, 04 May 2012 18:39:06 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> Il 04/05/2012 17:02, Luiz Capitulino ha scritto:
> > diff --git a/qapi-schema.json b/qapi-schema.json
> > index 0166ec2..4dbcb26 100644
> > --- a/qapi-schema.json
> > +++ b/qapi-schema.json
> > @@ -116,12 +116,14 @@
> >  #
> >  # @shutdown: guest is shut down (and -no-shutdown is in use)
> >  #
> > +# @suspended: guest is suspended (ACPI S3)
> > +#
> >  # @watchdog: the watchdog action is configured to pause and has been triggered
> >  ##
> >  { 'enum': 'RunState',
> >    'data': [ 'debug', 'inmigrate', 'internal-error', 'io-error', 'paused',
> >              'postmigrate', 'prelaunch', 'finish-migrate', 'restore-vm',
> > -            'running', 'save-vm', 'shutdown', 'watchdog' ] }
> > +            'running', 'save-vm', 'shutdown', 'suspended', 'watchdog' ] }
> >  
> 
> This breaks QAPI ABI.
> 
> Not really a breaker for this series, but it shows how we are not yet
> ready to keep a stable ABI (as opposed to API), and thus any

Having to add a new enum every time a new value is needed is going to be fun.