From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41677) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQM53-00034m-Si for qemu-devel@nongnu.org; Fri, 04 May 2012 13:14:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SQM52-0006kc-06 for qemu-devel@nongnu.org; Fri, 04 May 2012 13:14:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17412) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQM51-0006k3-OY for qemu-devel@nongnu.org; Fri, 04 May 2012 13:14:07 -0400 Date: Fri, 4 May 2012 14:13:50 -0300 From: Luiz Capitulino Message-ID: <20120504141350.3337d5d6@doriath.home> In-Reply-To: <4FA40CB7.6060804@redhat.com> References: <1336143722-15050-1-git-send-email-lcapitulino@redhat.com> <1336143722-15050-4-git-send-email-lcapitulino@redhat.com> <4FA4062A.8060207@redhat.com> <20120504135054.698444ec@doriath.home> <4FA40CB7.6060804@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/4] runstate: introduce suspended state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Paolo Bonzini , kraxel@redhat.com, mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org On Fri, 04 May 2012 11:07:03 -0600 Eric Blake wrote: > On 05/04/2012 10:50 AM, Luiz Capitulino wrote: > > On Fri, 04 May 2012 18:39:06 +0200 > > Paolo Bonzini wrote: > > > >> Il 04/05/2012 17:02, Luiz Capitulino ha scritto: > >>> diff --git a/qapi-schema.json b/qapi-schema.json > >>> index 0166ec2..4dbcb26 100644 > >>> --- a/qapi-schema.json > >>> +++ b/qapi-schema.json > >>> @@ -116,12 +116,14 @@ > >>> # > >>> # @shutdown: guest is shut down (and -no-shutdown is in use) > >>> # > >>> +# @suspended: guest is suspended (ACPI S3) > >>> +# > >>> # @watchdog: the watchdog action is configured to pause and has been triggered > >>> ## > >>> { 'enum': 'RunState', > >>> 'data': [ 'debug', 'inmigrate', 'internal-error', 'io-error', 'paused', > >>> 'postmigrate', 'prelaunch', 'finish-migrate', 'restore-vm', > >>> - 'running', 'save-vm', 'shutdown', 'watchdog' ] } > >>> + 'running', 'save-vm', 'shutdown', 'suspended', 'watchdog' ] } > >>> > >> > >> This breaks QAPI ABI. > >> > >> Not really a breaker for this series, but it shows how we are not yet > >> ready to keep a stable ABI (as opposed to API), and thus any > > > > Having to add a new enum every time a new value is needed is going to be fun. > > I think Paolo's point was that new values should be added at the end of > the list. Your patch, as written, changes 'watchdog' from 13th to 14th; > what you should have done is left 'watchdog' at 13th and made > 'suspended' be 14th. We don't have a stable QAPI ABI today, and if I'm not missing the point here he's advocating against it. I don't think this series need any changes in that regard.