From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:48089)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SRDbh-0004U9-6H
	for qemu-devel@nongnu.org; Sun, 06 May 2012 22:23:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SRDbf-0004L6-Fp
	for qemu-devel@nongnu.org; Sun, 06 May 2012 22:23:24 -0400
Received: from mx1.redhat.com ([209.132.183.28]:13880)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1SRDbf-0004Kk-7X
	for qemu-devel@nongnu.org; Sun, 06 May 2012 22:23:23 -0400
Date: Sun, 6 May 2012 23:23:31 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120506232331.12816080@doriath.home>
In-Reply-To: <4FA4DCF7.1050301@redhat.com>
References: <1336143722-15050-1-git-send-email-lcapitulino@redhat.com>
	<1336143722-15050-4-git-send-email-lcapitulino@redhat.com>
	<4FA4062A.8060207@redhat.com>
	<20120504135054.698444ec@doriath.home>
	<4FA40CB7.6060804@redhat.com>
	<20120504141350.3337d5d6@doriath.home>
	<4FA4DCF7.1050301@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/4] runstate: introduce suspended state
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, Eric Blake <eblake@redhat.com>, kraxel@redhat.com, mdroth@linux.vnet.ibm.com

On Sat, 05 May 2012 09:55:35 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> Il 04/05/2012 19:13, Luiz Capitulino ha scritto:
> >>>> > >> This breaks QAPI ABI.
> >>>> > >>
> >>>> > >> Not really a breaker for this series, but it shows how we are not yet
> >>>> > >> ready to keep a stable ABI (as opposed to API), and thus any
> >>> > > 
> >>> > > Having to add a new enum every time a new value is needed is going to be fun.
> >> > 
> >> > I think Paolo's point was that new values should be added at the end of
> >> > the list.  Your patch, as written, changes 'watchdog' from 13th to 14th;
> >> > what you should have done is left 'watchdog' at 13th and made
> >> > 'suspended' be 14th.
> > 
> > We don't have a stable QAPI ABI today, and if I'm not missing the point
> > here he's advocating against it.
> 
> Yes, but Eric's solution would be fine.

I'm afraid not, we generate a _MAX enum for bound checking. Yet another
argument in favor of your first call.